Re: master b0049c942b8: bytecomp.el: Warn for `, ' not within backquote construct

Re: master b0049c942b8: bytecomp.el: Warn for `, ' not within backquote construct

[Po Lu]

"Richard M. Stallman" <rms@gnu.org> writes:

> branch: master
> commit b0049c942b8fa4093a02a9bb4ffc9c5da2261765
> Author: Richard M Stallman <rms@gnu.org>
> Commit: Richard Stallman <rms@gnu.org>
>
>     bytecomp.el: Warn for `,' not within backquote construct
>     
>     (bytecomp--report-comma): New function with `compiler-macro' property.

Richard, our ChangeLog generator script is not sophisticated enough to
extract file names from the title of a commit.  Instead, please move the
file name to a separate line, in the format of a ChangeLog entry:

* lisp/emacs-lisp/bytecomp.el:

Thanks.

Re: master b0049c942b8: bytecomp.el: Warn for `, ' not within backquote construct

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > Richard, our ChangeLog generator script is not sophisticated enough to
  > extract file names from the title of a commit.  Instead, please move the
  > file name to a separate line, in the format of a ChangeLog entry:

  > * lisp/emacs-lisp/bytecomp.el:

1. The format I used on Feb 3 was the same as used in the previous
commit for that same file.  What exactly are you asking me to do
differently?

2.  How could I change it now that it is already pushed?


-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: master b0049c942b8: bytecomp.el: Warn for `, ' not within backquote construct

[Eli Zaretskii]

> From: Richard Stallman <rms@gnu.org>
> Cc: emacs-devel@gnu.org
> Date: Sun, 04 Feb 2024 22:36:13 -0500
> 
>   > Richard, our ChangeLog generator script is not sophisticated enough to
>   > extract file names from the title of a commit.  Instead, please move the
>   > file name to a separate line, in the format of a ChangeLog entry:
> 
>   > * lisp/emacs-lisp/bytecomp.el:
> 
> 1. The format I used on Feb 3 was the same as used in the previous
> commit for that same file.  What exactly are you asking me to do
> differently?

To name the file name before the function name:

  * lisp/emacs-lisp/bytecomp.el (bytecomp--report-comma): New function with...

You could still mention the file name in the heading line (the 1st
line of the log message), it does no harm to have the file mentioned
twice.

> 2.  How could I change it now that it is already pushed?

You cannot.  We can only edit by hand the produced ChangeLog when the
next release's tarball is being prepared.

Re: master b0049c942b8: bytecomp.el: Warn for `, ' not within backquote construct

[Stefan Monnier via Emacs development discussions.]

>>     bytecomp.el: Warn for `,' not within backquote construct
>>     (bytecomp--report-comma): New function with `compiler-macro' property.

BTW, the compiler already emitted a warning for it, but saying only
that there was a call to an unknown function `,`, and without specifying
where that call was found.

So now we get a duplicate warning:

    In my-foo:
    foo.el:4:7: Warning: ‘,’ called -- perhaps used not within backquote
    
    In end of data:
    foo.el: Warning: the function ‘,’ is not known to be defined.

Maybe the better fix is to improve the "function ‘,’ is not known to
be defined" warning so it points to the right location?


        Stefan

Re: master b0049c942b8: bytecomp.el: Warn for `, ' not within backquote construct

[Richard Stallman]

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > BTW, the compiler already emitted a warning for it, but saying only
  > that there was a call to an unknown function `,`, and without specifying
  > where that call was found.

Right.  It was very difficult to find where that warning was coming from.
It turns out that searching for a comma finds lots of matches that
do not represent anything wrong.

  > So now we get a duplicate warning:

  >     In my-foo:
  >     foo.el:4:7: Warning: ‘,’ called -- perhaps used not within backquote
    
  >     In end of data:
  >     foo.el: Warning: the function ‘,’ is not known to be defined.

The mew warning (shown first above) is better), so I'd suggest disabling
the old (second) warning for this function.

  > Maybe the better fix is to improve the "function ‘,’ is not known to
  > be defined" warning so it points to the right location?

It would be useful to improve the "function XYZ is not known to be defined"
warning in that way -- but, in the special case of comma, the newer
more specific warning is better.



-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Re: master b0049c942b8: bytecomp.el: Warn for `, ' not within backquote construct

[Stefan Monnier]

>   >     In my-foo:
>   >     foo.el:4:7: Warning: ‘,’ called -- perhaps used not within backquote
>     
>   >     In end of data:
>   >     foo.el: Warning: the function ‘,’ is not known to be defined.
>
> The mew warning (shown first above) is better), so I'd suggest disabling
> the old (second) warning for this function.

Reminds me that I have fun definitions for toplevel uses of `,` and `,@`
to propose:

    (defmacro \,@ (exp)
      "Splice EXP's value (a list of Lisp forms) into the code."
      (declare (debug t))
      `(progn ,@(eval exp t)))

    (defmacro \, (exp)
      "Splice EXP's value (a Lisp form) into the code."
      (declare (debug t))
      (eval exp t))

The first one is already available under the names `gnus--,@` and `ses--,@`.


        Stefan