all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#4568: version test in .elc files is too complicated
@ 2009-09-28  2:10 Dan Nicolaescu
  2009-09-28  5:45 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Dan Nicolaescu @ 2009-09-28  2:10 UTC (permalink / raw)
  To: bug-gnu-emacs


The version test in all the .elc files is too complicated:

(if (and (boundp 'emacs-version)
         (< (aref emacs-version (1- (length emacs-version))) ?A)
         (or (and (boundp 'epoch::version) epoch::version)
           (string-lessp emacs-version "19.29")))
    (error "`vc-hooks.el' was compiled for Emacs 19.29 or later"))

if anyone still runs epoch (very doubtful), there are many other things
that will fail when trying to run emacs-23 byte compiled code.

This was discussed on emacs-devel some time ago (can't find the link at
the moment), but nothing happened.

IMVHO a single condition based on emacs-major-version should be enough.






^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#4568: version test in .elc files is too complicated
  2009-09-28  2:10 bug#4568: version test in .elc files is too complicated Dan Nicolaescu
@ 2009-09-28  5:45 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2009-09-28  5:45 UTC (permalink / raw)
  To: Dan Nicolaescu; +Cc: bug-gnu-emacs, 4568

> The version test in all the .elc files is too complicated:

Please just remove it.


        Stefan





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-09-28  5:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-28  2:10 bug#4568: version test in .elc files is too complicated Dan Nicolaescu
2009-09-28  5:45 ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.