From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#7350: 24.0.50; make vc-deduce-backend smarter Date: Mon, 15 Nov 2010 11:05:11 -0500 Message-ID: References: <19669.54304.980911.220632@rgr.rgrjr.com> <19671.7412.608640.593137@rgr.rgrjr.com> <19672.26151.150217.308712@rgr.rgrjr.com> <19680.28414.314610.707478@rgr.rgrjr.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1289837665 12838 80.91.229.12 (15 Nov 2010 16:14:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 15 Nov 2010 16:14:25 +0000 (UTC) Cc: 7350@debbugs.gnu.org To: Bob Rogers Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 15 17:14:21 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PI1hA-0005cQ-EO for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Nov 2010 17:14:16 +0100 Original-Received: from localhost ([127.0.0.1]:42122 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI1hA-0008GP-2A for geb-bug-gnu-emacs@m.gmane.org; Mon, 15 Nov 2010 11:14:16 -0500 Original-Received: from [140.186.70.92] (port=53550 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PI1h3-0008Fy-VJ for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2010 11:14:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PI1h2-0007VD-Hv for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2010 11:14:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53408) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PI1h2-0007V5-CC for bug-gnu-emacs@gnu.org; Mon, 15 Nov 2010 11:14:08 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PI1UL-0000Zi-Te; Mon, 15 Nov 2010 11:01:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Nov 2010 16:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7350 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7350-submit@debbugs.gnu.org id=B7350.12898368182204 (code B ref 7350); Mon, 15 Nov 2010 16:01:01 +0000 Original-Received: (at 7350) by debbugs.gnu.org; 15 Nov 2010 16:00:18 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PI1Td-0000ZV-TM for submit@debbugs.gnu.org; Mon, 15 Nov 2010 11:00:18 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183] helo=ironport2-out.pppoe.ca) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PI1Tb-0000ZQ-BT for 7350@debbugs.gnu.org; Mon, 15 Nov 2010 11:00:16 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av0GAL/o4ExFpY76/2dsb2JhbAChWX5yviaDBAiCPgSEWo1f X-IronPort-AV: E=Sophos;i="4.59,200,1288584000"; d="scan'208";a="82587925" Original-Received: from 69-165-142-250.dsl.teksavvy.com (HELO pastel.home) ([69.165.142.250]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 15 Nov 2010 11:05:11 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 7060EA8263; Mon, 15 Nov 2010 11:05:11 -0500 (EST) In-Reply-To: <19680.28414.314610.707478@rgr.rgrjr.com> (Bob Rogers's message of "Sun, 14 Nov 2010 18:21:34 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 15 Nov 2010 11:01:01 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:41637 Archived-At: > Hmm. TRT would be to figure this out in the "interactive" form, so that > repeat-complex-command works, but that would change the args to vc-diff. > How big a change are you willing to contemplate? A largish patch is not a problem in and of itself (except for copyright reasons, but once you've signed the paperwork it's a non-issue). So the only reason to reject such a change would be if it made the code conceptually more tricky/complex. From the sound of it, it would make it actually more regular, more in line with the usual way commands work in Emacs, so it seems OK. Of course, there is also the risk of introducing bugs/incompatibilities, so try and make extra sure you take into account all callers. Stefan