From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Bob Rogers <rogers@rgrjr.dyndns.org>
Cc: 7350@debbugs.gnu.org
Subject: bug#7350: 24.0.50; make vc-deduce-backend smarter
Date: Mon, 15 Nov 2010 11:05:11 -0500 [thread overview]
Message-ID: <jwvy68uinjf.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <19680.28414.314610.707478@rgr.rgrjr.com> (Bob Rogers's message of "Sun, 14 Nov 2010 18:21:34 -0500")
> Hmm. TRT would be to figure this out in the "interactive" form, so that
> repeat-complex-command works, but that would change the args to vc-diff.
> How big a change are you willing to contemplate?
A largish patch is not a problem in and of itself (except for copyright
reasons, but once you've signed the paperwork it's a non-issue). So the
only reason to reject such a change would be if it made the code
conceptually more tricky/complex. From the sound of it, it would make
it actually more regular, more in line with the usual way commands work
in Emacs, so it seems OK.
Of course, there is also the risk of introducing bugs/incompatibilities,
so try and make extra sure you take into account all callers.
Stefan
next prev parent reply other threads:[~2010-11-15 16:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-06 22:18 bug#7350: 24.0.50; make vc-deduce-backend smarter Bob Rogers
2010-11-07 20:03 ` Stefan Monnier
2010-11-07 21:41 ` Bob Rogers
2010-11-08 17:47 ` Stefan Monnier
2010-11-08 21:05 ` Bob Rogers
2010-11-12 13:48 ` Stefan Monnier
2010-11-14 23:21 ` Bob Rogers
2010-11-15 16:05 ` Stefan Monnier [this message]
2010-11-17 4:43 ` Bob Rogers
2010-11-17 13:31 ` Stefan Monnier
2010-11-19 2:27 ` Bob Rogers
2010-11-20 19:54 ` Bob Rogers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy68uinjf.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=7350@debbugs.gnu.org \
--cc=rogers@rgrjr.dyndns.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.