From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Drew Adams" <drew.adams@oracle.com>
Cc: emacs-devel@gnu.org
Subject: Re: can we please define a face for compile.el mouseover?
Date: Sat, 19 Feb 2011 16:11:25 -0500 [thread overview]
Message-ID: <jwvy65bg2m0.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <B7CF6289AAB64976978C7FEA60569598@us.oracle.com> (Drew Adams's message of "Tue, 15 Feb 2011 20:03:23 -0800")
> When mouse-face highlighting is on a full line I find simple
> underlining better than a flashy background. That's my preference,
> but the point is that mouseover highlighting on a long line has
> a different effect visually than it does on a short name or a button.
I see what you mean and I partly agree. So part of the reason you want
a different face is because you mouse-highlight the whole line.
But admittedly, the regexps we use in compile.el seem to cover
potentially long chunks of text, even without extending them to cover
the whole line. Maybe we should add a new face `long-highlight',
inheriting from highlight and use it in compilation, or on the contrary
maybe we should try and reduce the size of the mouse-highlighted text.
> rows and code lines, (c) buttons, and (d) mode-line constructs (treated
> generally as buttons, but worth treating as a separate case - as they in
> fact are).
BTW, the reason why mode-line-highlight is different is very simple: the
mode-line face is very different from the default face, so using
`highlight' for mouse-over on the mode line looks bad in most
configurations, including the default one.
>> So if there's a good reason why this particular case is likely to
>> happen to many users, a customization variable might be justified, but
>> otherwise having a generic solution (e.g. face-remapping) seems quite
>> sufficient.
> Sigh. Same song you've sung previously to defend hard-coding
> `highlight'...
Of course, it's the leading theme of software maintenance.
Stefan
next prev parent reply other threads:[~2011-02-19 21:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-15 19:26 can we please define a face for compile.el mouseover? Drew Adams
2011-02-15 19:42 ` Eli Zaretskii
2011-02-15 22:43 ` Drew Adams
2011-02-15 21:12 ` Stefan Monnier
2011-02-15 22:41 ` Drew Adams
2011-02-16 2:32 ` Stefan Monnier
2011-02-16 4:03 ` Drew Adams
2011-02-19 21:11 ` Stefan Monnier [this message]
2011-02-19 21:32 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy65bg2m0.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.