From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: 5x5 Arithmetic solver Date: Fri, 20 May 2011 10:45:02 -0300 Message-ID: References: <80wrhmfnku.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1305899117 24163 80.91.229.12 (20 May 2011 13:45:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 20 May 2011 13:45:17 +0000 (UTC) Cc: Jay P Belanger , emacs-devel@gnu.org, Dave Pearson To: Vincent =?iso-8859-1?Q?Bela=EFche?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri May 20 15:45:13 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QNQ0u-0004fQ-MS for ged-emacs-devel@m.gmane.org; Fri, 20 May 2011 15:45:12 +0200 Original-Received: from localhost ([::1]:47867 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNQ0s-000612-W6 for ged-emacs-devel@m.gmane.org; Fri, 20 May 2011 09:45:10 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:33827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNQ0q-00060S-Kc for emacs-devel@gnu.org; Fri, 20 May 2011 09:45:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QNQ0p-0007Ry-La for emacs-devel@gnu.org; Fri, 20 May 2011 09:45:08 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]:34242) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QNQ0p-0007Rq-JV for emacs-devel@gnu.org; Fri, 20 May 2011 09:45:07 -0400 Original-Received: from 213-159-126-200.fibertel.com.ar ([200.126.159.213]:40629 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QNQ0o-0006U3-FY; Fri, 20 May 2011 09:45:06 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id A77436621E; Fri, 20 May 2011 10:45:02 -0300 (ART) In-Reply-To: <80wrhmfnku.fsf@gmail.com> ("Vincent =?iso-8859-1?Q?Bela=EFch?= =?iso-8859-1?Q?e=22's?= message of "Thu, 19 May 2011 22:21:53 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.10 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:139545 Archived-At: > Please find herein attached a contribution to the 5x5 game. This is an > arithmetic solver based on a matrix inversion in a (Z/2Z)^25 vector > space. Thanks. A few comments: - avoid using a tarball and just attach the diff as-is, makes it a lot easier to review. - why 5x5-local-variables? - explain the changes in the 5x5 function. - many of your lines have trailing whitespace. I generally don't care much, about it, but some people do, and it's usually preferable to avoid them. M-x picture-mode C-c C-c gets rid of them for you (as a side-effect). - try to keep the first line of docstrings as a self-sufficient sentence (because M-x apropos only shows the first line). - stay within 80 columns. - your code is not properly indented (e.g. the `grid' argument in 5x5-grid-to-vec). - Please capitalize your comments and terminate them with a "." or some other appropriate punctuation. - 5x5-solve-suggest should have a docstring. - try C-u checkdoc-current-buffer. - we need a ChangeLog entry. - I don't understand the "solve step" message (e.g. it said 23 every time, even though I followed its suggestions and finished in 12 moves). Stefan