From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Vincent Belaïche" <vincent.b.1@hotmail.fr>
Cc: Jay P Belanger <jay.p.belanger@gmail.com>,
emacs-devel@gnu.org, Dave Pearson <davep@davep.org>
Subject: Re: 5x5 Arithmetic solver
Date: Fri, 20 May 2011 10:45:02 -0300 [thread overview]
Message-ID: <jwvy621v6yn.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <80wrhmfnku.fsf@gmail.com> ("Vincent Belaïche"'s message of "Thu, 19 May 2011 22:21:53 +0200")
> Please find herein attached a contribution to the 5x5 game. This is an
> arithmetic solver based on a matrix inversion in a (Z/2Z)^25 vector
> space.
Thanks. A few comments:
- avoid using a tarball and just attach the diff as-is,
makes it a lot easier to review.
- why 5x5-local-variables?
- explain the changes in the 5x5 function.
- many of your lines have trailing whitespace. I generally don't care
much, about it, but some people do, and it's usually preferable to
avoid them. M-x picture-mode C-c C-c gets rid of them for you (as
a side-effect).
- try to keep the first line of docstrings as a self-sufficient sentence
(because M-x apropos only shows the first line).
- stay within 80 columns.
- your code is not properly indented (e.g. the `grid' argument in
5x5-grid-to-vec).
- Please capitalize your comments and terminate them with a "." or some
other appropriate punctuation.
- 5x5-solve-suggest should have a docstring.
- try C-u checkdoc-current-buffer.
- we need a ChangeLog entry.
- I don't understand the "solve step" message (e.g. it said 23 every
time, even though I followed its suggestions and finished in 12 moves).
Stefan
next prev parent reply other threads:[~2011-05-20 13:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 20:21 5x5 Arithmetic solver Vincent Belaïche
2011-05-20 13:45 ` Stefan Monnier [this message]
2011-05-20 14:03 ` Antoine Levitt
2011-05-21 6:38 ` Vincent Belaïche
-- strict thread matches above, loose matches on Subject: below --
2011-05-21 7:15 Vincent Belaïche
2011-05-21 7:49 ` Eli Zaretskii
2011-05-21 14:36 ` Vinicius Jose Latorre
2011-05-21 16:12 ` Vincent Belaïche
2011-05-21 23:29 ` Stefan Monnier
2011-05-21 18:15 Vincent Belaïche
2011-05-21 19:03 ` Eli Zaretskii
2011-05-21 23:31 ` Stefan Monnier
2011-05-22 7:32 ` Vincent Belaïche
2011-05-22 19:09 ` Stefan Monnier
2011-05-22 20:35 Vincent Belaïche
2011-05-23 14:47 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy621v6yn.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=davep@davep.org \
--cc=emacs-devel@gnu.org \
--cc=jay.p.belanger@gmail.com \
--cc=vincent.b.1@hotmail.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.