From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: changes to cfengine-mode Date: Tue, 13 Dec 2011 14:51:48 -0500 Message-ID: References: <87ipmcgjot.fsf@lifelogs.com> <83lir89gne.fsf@gnu.org> <87aa7ogfo3.fsf@lifelogs.com> <87fwhffv37.fsf@lifelogs.com> <877h2ridev.fsf@gnu.org> <8739dfezc1.fsf@lifelogs.com> <87aa7m5a6b.fsf@gnu.org> <877h2oe3yj.fsf@lifelogs.com> <877h2ngnhb.fsf@marauder.physik.uni-ulm.de> <87hb1qb9ot.fsf@lifelogs.com> <87pqg82tdy.fsf@lifelogs.com> <87pqg7x89t.fsf_-_@lifelogs.com> <8739cwtzh8.fsf@lifelogs.com> <87iplk9ylb.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT X-Trace: dough.gmane.org 1323805935 25270 80.91.229.12 (13 Dec 2011 19:52:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 13 Dec 2011 19:52:15 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 13 20:52:10 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RaYOX-00023d-8d for ged-emacs-devel@m.gmane.org; Tue, 13 Dec 2011 20:52:09 +0100 Original-Received: from localhost ([::1]:41290 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaYOW-0006CG-PR for ged-emacs-devel@m.gmane.org; Tue, 13 Dec 2011 14:52:08 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:35808) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaYOT-00069X-OE for emacs-devel@gnu.org; Tue, 13 Dec 2011 14:52:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RaYOR-0005Bx-Ol for emacs-devel@gnu.org; Tue, 13 Dec 2011 14:52:05 -0500 Original-Received: from relais.videotron.ca ([24.201.245.36]:11310) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RaYOR-0005Bs-Jr for emacs-devel@gnu.org; Tue, 13 Dec 2011 14:52:03 -0500 Original-Received: from ceviche.home ([173.176.12.77]) by VL-VM-MR002.ip.videotron.ca (Oracle Communications Messaging Exchange Server 7u4-22.01 64bit (built Apr 21 2011)) with ESMTP id <0LW500A6QQW9LZ80@VL-VM-MR002.ip.videotron.ca> for emacs-devel@gnu.org; Tue, 13 Dec 2011 14:45:45 -0500 (EST) Original-Received: by ceviche.home (Postfix, from userid 20848) id 37758662EE; Tue, 13 Dec 2011 14:51:48 -0500 (EST) In-reply-to: <87iplk9ylb.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 24.201.245.36 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:146694 Archived-At: >>> 2) rename all the "cfengine-*" variables used only by `cfengine2-mode' >>> to "cfengine2-*" SM> Is this needed? Do these variables only make sense for cfengine2 syntax? > Yes, I renamed those that are only for cfengine2. There's a difference between "only used for cfengine2" and "only makes sense for cfengine2". E.g. it might only be used for cfengine2 because it's just not implemented for cfengine3 (e.g. for lack of resources, or because some other generic Emacs feature can be used instead). Basically, renaming user variables is a hassle, so it should only be done when it's really needed, e.g. to avoid conflicts or fix a real problem. > I'll commit the revised code after 24.1 is out. I'd like to see the shuffle (cfengine-mode->cfengine2-mode and cfengine-auto-mode->cfengine-mode) be in Emacs-24.1. You can include the docfixes at the same time. SM> *Messages* tells me: SM> Error during redisplay: (void-variable font-lock-constant-name-face) > I don't know why it says that. That variable is defined in > font-lock.el, right? Or am I missing something? Yes, you're missing the fact that it's not defined ;-) BTW, to debug font-lock problem, I recommend you start by (setq font-lock-support-mode nil), so that debug-on-error works. Stefan