From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#11328: 24.1.50; Comment in `dired-copy-file-recursive' code Date: Tue, 24 Apr 2012 14:54:55 -0400 Message-ID: References: <0CC212AF2EA740A0B8FE5EEF91077A2D@us.oracle.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1335293729 3709 80.91.229.3 (24 Apr 2012 18:55:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 24 Apr 2012 18:55:29 +0000 (UTC) Cc: 11328@debbugs.gnu.org To: "Drew Adams" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Apr 24 20:55:28 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SMktb-0008Gy-GX for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Apr 2012 20:55:27 +0200 Original-Received: from localhost ([::1]:59884 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMkta-0003Bm-Rq for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Apr 2012 14:55:26 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40631) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMktU-0003BU-7R for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 14:55:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SMktN-0007Lj-RK for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 14:55:19 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50065) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SMktN-0007LI-NU for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 14:55:13 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SMku9-0004zj-Pi for bug-gnu-emacs@gnu.org; Tue, 24 Apr 2012 14:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Apr 2012 18:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11328 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11328-submit@debbugs.gnu.org id=B11328.133529374919179 (code B ref 11328); Tue, 24 Apr 2012 18:56:01 +0000 Original-Received: (at 11328) by debbugs.gnu.org; 24 Apr 2012 18:55:49 +0000 Original-Received: from localhost ([127.0.0.1]:51099 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMktw-0004zH-8n for submit@debbugs.gnu.org; Tue, 24 Apr 2012 14:55:48 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:51730) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SMktt-0004z7-Ha for 11328@debbugs.gnu.org; Tue, 24 Apr 2012 14:55:46 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q3OIsuUk006142; Tue, 24 Apr 2012 14:54:56 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id D9467B4018; Tue, 24 Apr 2012 14:54:55 -0400 (EDT) In-Reply-To: <0CC212AF2EA740A0B8FE5EEF91077A2D@us.oracle.com> (Drew Adams's message of "Tue, 24 Apr 2012 10:37:09 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.94 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4202=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4202> : streams <749803> : uri <1103158> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59463 Archived-At: I really appreciate your nit-picks (I know the word sounds negative, but to improve code-quality, it's really what is needed). But please, please, pretty please, get yourself access to the Bzr so you can fix those things yourself. You'll be happier, we'll be happier, the world will smile, birds will sing. Stefan >>>>> "Drew" == Drew Adams writes: > Just a nit. But if you are going to add unnecessary comments to the > code that describe only what everyone can see the code does, then at > least get them right. Otherwise you mislead readers. > This comment is incorrect: "Not a directory". What is actually true at > that point is the following; > a. RECURSIVE is nil > b. RECURSIVE is non-nil and this is not a directory > c. this is a directory, RECURSIVE is non-nil and not `always', > and the user replied `n' > (Similarly, the comment "This is a directory", though true, does not > convey the real meaning. It is a directory AND it should be copied > recursively.) > It is a bad habit to add such comments to the code. Comments should > generally be used when it is not obvious what the code does or why. > In GNU Emacs 24.1.50.1 (i386-mingw-nt5.1.2600) > of 2012-04-23 on MARVIN > Bzr revision: 108006 > agustin.martin@hispalinux.es-20120423103325-xmra3329elgzhmpc > Windowing system distributor `Microsoft Corp.', version 5.1.2600 > Configured using: > `configure --with-gcc (4.6) --no-opt --enable-checking --cflags > -ID:/devel/emacs/libs/libXpm-3.5.8/include > -ID:/devel/emacs/libs/libXpm-3.5.8/src > -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include > -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include > -ID:/devel/emacs/libs/giflib-4.1.4-1/include > -ID:/devel/emacs/libs/jpeg-6b-4/include > -ID:/devel/emacs/libs/tiff-3.8.2-1/include > -ID:/devel/emacs/libs/gnutls-3.0.9/include > -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include > -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2'