From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: testcover: setf-method and treatment of `defcustom' Date: Tue, 18 Sep 2012 17:37:23 -0400 Message-ID: References: <6900.1347261102@theowa.merten-home.homelinux.org> <13361.1347786412@eskebo.merten-home.homelinux.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1348004251 29974 80.91.229.3 (18 Sep 2012 21:37:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 18 Sep 2012 21:37:31 +0000 (UTC) Cc: Jonathan Yavner , emacs-devel@gnu.org To: Stefan Merten Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Sep 18 23:37:34 2012 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TE5U5-00068y-Qk for ged-emacs-devel@m.gmane.org; Tue, 18 Sep 2012 23:37:33 +0200 Original-Received: from localhost ([::1]:33324 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE5U1-0004f7-LD for ged-emacs-devel@m.gmane.org; Tue, 18 Sep 2012 17:37:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:54378) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE5Tz-0004eA-CD for emacs-devel@gnu.org; Tue, 18 Sep 2012 17:37:28 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TE5Tx-0005BV-Fr for emacs-devel@gnu.org; Tue, 18 Sep 2012 17:37:27 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:50540) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TE5Tx-0005BI-CB for emacs-devel@gnu.org; Tue, 18 Sep 2012 17:37:25 -0400 Original-Received: from faina.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id q8ILbNrR029666; Tue, 18 Sep 2012 17:37:23 -0400 Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id 7D891B4071; Tue, 18 Sep 2012 17:37:23 -0400 (EDT) In-Reply-To: <13361.1347786412@eskebo.merten-home.homelinux.org> (Stefan Merten's message of "Sun, 16 Sep 2012 11:06:52 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:153385 Archived-At: > My cent: Before pushing VAL. AFAICS `testcover-after' needs to see > PLACE unmodified. Then please try the patch below instead. Stefan === modified file 'lisp/emacs-lisp/testcover.el' --- lisp/emacs-lisp/testcover.el 2012-01-19 07:21:25 +0000 +++ lisp/emacs-lisp/testcover.el 2012-09-11 03:38:33 +0000 @@ -447,6 +447,13 @@ (defun testcover-after (idx val) "Internal function for coverage testing. Returns VAL after installing it in `testcover-vector' at offset IDX." + (declare (gv-expander (lambda (do) + (gv-letplace (getter setter) val + (funcall do getter + (lambda (store) + (macroexp-let2 nil s store + `(progn (testcover-after ,idx ,getter) + ,(funcall setter s))))))))) (cond ((eq (aref testcover-vector idx) 'unknown) (aset testcover-vector idx val))