From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Stefan Merten <smerten@oekonux.de>
Cc: Jonathan Yavner <jyavner@member.fsf.org>, emacs-devel@gnu.org
Subject: Re: testcover: setf-method and treatment of `defcustom'
Date: Tue, 18 Sep 2012 17:37:23 -0400 [thread overview]
Message-ID: <jwvy5k7c8u2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <13361.1347786412@eskebo.merten-home.homelinux.org> (Stefan Merten's message of "Sun, 16 Sep 2012 11:06:52 +0200")
> My cent: Before pushing VAL. AFAICS `testcover-after' needs to see
> PLACE unmodified.
Then please try the patch below instead.
Stefan
=== modified file 'lisp/emacs-lisp/testcover.el'
--- lisp/emacs-lisp/testcover.el 2012-01-19 07:21:25 +0000
+++ lisp/emacs-lisp/testcover.el 2012-09-11 03:38:33 +0000
@@ -447,6 +447,13 @@
(defun testcover-after (idx val)
"Internal function for coverage testing. Returns VAL after installing it in
`testcover-vector' at offset IDX."
+ (declare (gv-expander (lambda (do)
+ (gv-letplace (getter setter) val
+ (funcall do getter
+ (lambda (store)
+ (macroexp-let2 nil s store
+ `(progn (testcover-after ,idx ,getter)
+ ,(funcall setter s)))))))))
(cond
((eq (aref testcover-vector idx) 'unknown)
(aset testcover-vector idx val))
next prev parent reply other threads:[~2012-09-18 21:37 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 7:11 testcover: setf-method and treatment of `defcustom' Stefan Merten
2012-09-11 3:40 ` Stefan Monnier
2012-09-12 20:38 ` Stefan Merten
2012-09-13 13:09 ` Stefan Monnier
2012-09-13 20:45 ` Stefan Merten
2012-09-16 9:06 ` Stefan Merten
2012-09-18 21:37 ` Stefan Monnier [this message]
2012-09-12 19:32 ` Stefan Merten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy5k7c8u2.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=jyavner@member.fsf.org \
--cc=smerten@oekonux.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.