Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111661: * progmodes/compile.el (compilation-start-hook): Simplify docstring.

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111661: * progmodes/compile.el (compilation-start-hook): Simplify docstring.

[Stefan Monnier]

> -  "List of hook functions run by `compilation-start' on the compilation process.
> -\(See `run-hook-with-args').
> -If you use \"omake -P\" and do not want \\[save-buffers-kill-terminal] to ask whether you want
> -the compilation to be killed, you can use this hook:
> -  (add-hook 'compilation-start-hook
> -    (lambda (process) (set-process-query-on-exit-flag process nil)) nil t)"
> +  "Hook run after starting a new compilation process.  The hook
> +is run with one argument, the new process."

I like part of this simplification, but the first line of a docstring
should "stand on its own" (i.e. it shouldn't end in the middle of
a sentence).  In this case, the best is to cut the line between
"process." and "The hook".


        Stefan

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111661: * progmodes/compile.el (compilation-start-hook): Simplify docstring.

[Christopher Schmidt]

Stefan Monnier <monnier@iro.umontreal.ca> writes:
> I like part of this simplification, but the first line of a docstring
> should "stand on its own" (i.e. it shouldn't end in the middle of
> a sentence).  In this case, the best is to cut the line between
> "process." and "The hook".

Didn't I fix this in 111662?

I am sorry for the inconvenience.  :(

        Christopher

Re: [Emacs-diffs] /srv/bzr/emacs/trunk r111661: * progmodes/compile.el (compilation-start-hook): Simplify docstring.

[Stefan Monnier]

>> I like part of this simplification, but the first line of a docstring
>> should "stand on its own" (i.e. it shouldn't end in the middle of
>> a sentence).  In this case, the best is to cut the line between
>> "process." and "The hook".
> Didn't I fix this in 111662?

You did, I just replied before I got to see that had fixed it already.

> I am sorry for the inconvenience.  :(

There's nothing to be sorry for.
And thanks for your contributions,


        Stefan