From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13594: 24.2.92; [PATCH] compilation-start doesn't consider nil OUTWIN Date: Thu, 14 Feb 2013 09:15:49 -0500 Message-ID: References: <87sj5apclq.fsf@mail.jurta.org> <87r4ktoinh.fsf@mail.jurta.org> <87mwvhxehw.fsf@mail.jurta.org> <87zjzfz0nq.fsf@mail.jurta.org> <51161554.9010609@gmx.at> <8738x4o5cp.fsf@mail.jurta.org> <5117D9B5.5090203@gmx.at> <87pq07b4k4.fsf@mail.jurta.org> <51192ADD.9010607@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1360851410 31792 80.91.229.3 (14 Feb 2013 14:16:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 14 Feb 2013 14:16:50 +0000 (UTC) Cc: 13594@debbugs.gnu.org To: Leo Liu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Feb 14 15:17:11 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U5zcU-00069q-E2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Feb 2013 15:17:02 +0100 Original-Received: from localhost ([::1]:53640 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5zcA-0001aN-Ml for geb-bug-gnu-emacs@m.gmane.org; Thu, 14 Feb 2013 09:16:42 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:34680) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5zc3-0001a1-Ke for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2013 09:16:41 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U5zbt-0004OU-HK for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2013 09:16:35 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49848) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U5zbt-0004OJ-E5 for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2013 09:16:25 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1U5zcU-0005LX-3M for bug-gnu-emacs@gnu.org; Thu, 14 Feb 2013 09:17:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 14 Feb 2013 14:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13594 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13594-submit@debbugs.gnu.org id=B13594.136085139120469 (code B ref 13594); Thu, 14 Feb 2013 14:17:02 +0000 Original-Received: (at 13594) by debbugs.gnu.org; 14 Feb 2013 14:16:31 +0000 Original-Received: from localhost ([127.0.0.1]:55312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U5zby-0005K5-RO for submit@debbugs.gnu.org; Thu, 14 Feb 2013 09:16:31 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:46464) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U5zbw-0005Jt-2Z for 13594@debbugs.gnu.org; Thu, 14 Feb 2013 09:16:29 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r1EEFnhd031296; Thu, 14 Feb 2013 09:15:50 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 945136F8CF; Thu, 14 Feb 2013 09:15:49 -0500 (EST) In-Reply-To: (Leo Liu's message of "Thu, 14 Feb 2013 16:22:49 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4491=0 X-NAI-Spam-Version: 2.2.0.9309 : core <4491> : streams <906631> : uri <1345539> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:71271 Archived-At: >> What happens if we just return a minibuffer window to display-buffer? >> (still ugly as hell) > Have we reached an impasse? Is it advisable to go back to what Stefan > originally suggested? Basically, as it currently stands "don't display at all" can be done in 2 ways: - make it work only for those callers that are prepared for it: for this case, we could simply define a t return value (returned from an ACTION) to mean "not displayed". Ideally, display-buffer would return nil in this case, but returning t is OK as well. - make it work everywhere: then we need display-buffer to return a "dummy" window (i.e. an object that behaves like a window object but that is not displayed). I'm beginning to think the best choice is the first option: it requires no changes right away, and we can progressively change callers so that they can handle the "not displayed" case. Stefan