From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#18141: 24.4.50; saving .gz file breaks file coding Date: Wed, 06 Aug 2014 13:48:27 -0400 Message-ID: References: <9pzjfrwvsl.fsf@fencepost.gnu.org> <83iom5ptwv.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1407347374 22473 80.91.229.3 (6 Aug 2014 17:49:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 6 Aug 2014 17:49:34 +0000 (UTC) Cc: 18141@debbugs.gnu.org, Vincent Lefevre , yamaoka@jpl.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 06 19:49:25 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XF5L2-0004mj-GM for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Aug 2014 19:49:24 +0200 Original-Received: from localhost ([::1]:40345 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XF5L2-0001JI-5s for geb-bug-gnu-emacs@m.gmane.org; Wed, 06 Aug 2014 13:49:24 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53236) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XF5Kp-0001Hu-HV for bug-gnu-emacs@gnu.org; Wed, 06 Aug 2014 13:49:19 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XF5Kg-0002wB-DN for bug-gnu-emacs@gnu.org; Wed, 06 Aug 2014 13:49:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XF5Kg-0002w7-Ay for bug-gnu-emacs@gnu.org; Wed, 06 Aug 2014 13:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XF5Kf-00072D-Sx for bug-gnu-emacs@gnu.org; Wed, 06 Aug 2014 13:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Aug 2014 17:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18141-submit@debbugs.gnu.org id=B18141.140734733527028 (code B ref 18141); Wed, 06 Aug 2014 17:49:01 +0000 Original-Received: (at 18141) by debbugs.gnu.org; 6 Aug 2014 17:48:55 +0000 Original-Received: from localhost ([127.0.0.1]:60668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XF5KY-00071s-RA for submit@debbugs.gnu.org; Wed, 06 Aug 2014 13:48:55 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]:46093) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XF5KW-00071k-Vv for 18141@debbugs.gnu.org; Wed, 06 Aug 2014 13:48:53 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id AE0B084F3C; Wed, 6 Aug 2014 13:48:52 -0400 (EDT) Original-Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 9DCB01E5B74; Wed, 6 Aug 2014 13:48:27 -0400 (EDT) Original-Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id 78649B40CD; Wed, 6 Aug 2014 13:48:27 -0400 (EDT) In-Reply-To: <83iom5ptwv.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Aug 2014 17:36:00 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92207 Archived-At: > --- lisp/files.el~0 2014-06-29 06:54:20 +0300 > +++ lisp/files.el 2014-08-06 17:26:42 +0300 > @@ -4835,13 +4835,17 @@ > (nth 1 setmodes))) > (set-file-modes buffer-file-name > (logior (car setmodes) 128)))))) > - (let (success) > + (let ((filename-is-magic (find-file-name-handler buffer-file-name > + 'write-region)) > + success) > (unwind-protect > ;; Pass in nil&nil rather than point-min&max to indicate > ;; we're saving the buffer rather than just a region. > ;; write-region-annotate-functions may make us of it. > - (let ((coding-system-for-write writecoding) > - (coding-system-require-warning nil)) > + (let ((coding-system-for-write > + (if filename-is-magic coding-system-for-write writecoding)) > + (coding-system-require-warning > + (if filename-is-magic coding-system-require-warning))) > (write-region nil nil > buffer-file-name nil t buffer-file-truename) > (setq success t)) I can vaguely guess why that avoids the problem, but I'm having a hard time seeing why the above is "right". IOW it seems like an ugly workaround which may itself come with unintended consequences. Stefan