From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 18141@debbugs.gnu.org, Vincent Lefevre <vincent@vinc17.net>,
yamaoka@jpl.org
Subject: bug#18141: 24.4.50; saving .gz file breaks file coding
Date: Wed, 06 Aug 2014 13:48:27 -0400 [thread overview]
Message-ID: <jwvy4v1jys2.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <83iom5ptwv.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 06 Aug 2014 17:36:00 +0300")
> --- lisp/files.el~0 2014-06-29 06:54:20 +0300
> +++ lisp/files.el 2014-08-06 17:26:42 +0300
> @@ -4835,13 +4835,17 @@
> (nth 1 setmodes)))
> (set-file-modes buffer-file-name
> (logior (car setmodes) 128))))))
> - (let (success)
> + (let ((filename-is-magic (find-file-name-handler buffer-file-name
> + 'write-region))
> + success)
> (unwind-protect
> ;; Pass in nil&nil rather than point-min&max to indicate
> ;; we're saving the buffer rather than just a region.
> ;; write-region-annotate-functions may make us of it.
> - (let ((coding-system-for-write writecoding)
> - (coding-system-require-warning nil))
> + (let ((coding-system-for-write
> + (if filename-is-magic coding-system-for-write writecoding))
> + (coding-system-require-warning
> + (if filename-is-magic coding-system-require-warning)))
> (write-region nil nil
> buffer-file-name nil t buffer-file-truename)
> (setq success t))
I can vaguely guess why that avoids the problem, but I'm having a hard
time seeing why the above is "right". IOW it seems like an ugly
workaround which may itself come with unintended consequences.
Stefan
next prev parent reply other threads:[~2014-08-06 17:48 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-29 6:59 bug#18141: 24.4.50; saving .gz file breaks file coding Katsumi Yamaoka
2014-07-30 0:10 ` Glenn Morris
2014-07-30 2:36 ` Katsumi Yamaoka
2014-07-30 13:15 ` Katsumi Yamaoka
2014-08-05 8:34 ` Glenn Morris
2014-08-06 14:36 ` Eli Zaretskii
2014-08-06 16:43 ` Vincent Lefevre
2014-08-06 17:32 ` Eli Zaretskii
2014-08-06 19:08 ` Vincent Lefevre
2014-08-06 19:45 ` Eli Zaretskii
2014-08-07 0:31 ` Vincent Lefevre
2014-08-07 12:20 ` Stefan Monnier
2014-08-07 14:23 ` Vincent Lefevre
2014-08-11 1:06 ` Glenn Morris
2014-08-06 17:48 ` Stefan Monnier [this message]
2014-08-06 18:10 ` Eli Zaretskii
2014-08-07 0:45 ` Stefan Monnier
2014-08-07 15:14 ` Eli Zaretskii
2014-08-07 19:08 ` Stefan Monnier
2014-08-07 19:37 ` Eli Zaretskii
2014-08-07 20:43 ` Stefan Monnier
2014-08-08 5:51 ` Eli Zaretskii
2014-08-06 23:45 ` Glenn Morris
2014-08-07 0:03 ` Glenn Morris
2014-08-07 12:14 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy4v1jys2.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=18141@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=vincent@vinc17.net \
--cc=yamaoka@jpl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.