all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: 18351@debbugs.gnu.org
Cc: Alan Schmitt <alan.schmitt@polytechnique.org>
Subject: bug#18351: [Alan Schmitt] Small patch for gnus nnimap.el
Date: Thu, 28 Aug 2014 21:59:31 -0400	[thread overview]
Message-ID: <jwvy4u8hxc1.fsf-monnier+bug#18351@gnu.org> (raw)
In-Reply-To: <jwvha0wjdro.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Thu, 28 Aug 2014 21:19:13 -0400")

> I posted this on gnus.general a couple weeks ago, but nobody
> replied.  I'm thus wondering if emacs.devel might be a better place to
> send gnus patches. If not, could you please direct me to the correct place?

Both places are good choices.

> The problem with this function is that the list of deleted articles is
> reversed in every case, but it should only be reversed in the last case
> (when it was created considering each article in turn and pushing it
> onto the list, thus creating it in reverse). Attached is a patch fixing
> this.

The analysis looks good, and so does the patch.

> If you agree with this analysis, could you please apply this patch?

I can apply the patch, but since I'm not familiar with this code,
I'd like to hear some comment from one of the Gnus guys.

> I have a question about the code above. Why do the first two cases of
> the cond return a 't' at the end?

Very good question.  Probably hysterical raisins?


        Stefan





  reply	other threads:[~2014-08-29  1:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-29  1:19 bug#18351: [Alan Schmitt] Small patch for gnus nnimap.el Stefan Monnier
2014-08-29  1:59 ` Stefan Monnier [this message]
2014-09-22 12:29   ` Alan Schmitt
2014-10-04 22:10     ` Ted Zlatanov
2014-10-05  1:55       ` Stefan Monnier
2014-10-05 10:21       ` Alan Schmitt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='jwvy4u8hxc1.fsf-monnier+bug#18351@gnu.org' \
    --to=monnier@iro.umontreal.ca \
    --cc=18351@debbugs.gnu.org \
    --cc=alan.schmitt@polytechnique.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.