From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: phillip.lord@newcastle.ac.uk (Phillip Lord)
Cc: emacs-devel@gnu.org
Subject: Re: pre-command-hook with input methods
Date: Mon, 09 Feb 2015 11:13:12 -0500 [thread overview]
Message-ID: <jwvy4o7rrx2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87egpz14re.fsf@newcastle.ac.uk> (Phillip Lord's message of "Mon, 09 Feb 2015 15:30:45 +0000")
> Ah, sorry. The advice is actually on the variable, and no on the
> symbol stored in the variable? So it runs even if the value changes?
Ah, you're right that other packages won't use add-function, so they'll
stomp on our advice!
>> Maybe what you're after is just an input-event-hook?
> I think for consistency, the hook should run immediately before or after
> Emacs responds to C-u (or C-x) depending on whether it is pre- or post-.
> Effectively, the C-x of a C-xC-f is, I think equivalent to the first "a"
> of a "a`" post-fix input key sequence. The only reason that the former
> works fine for me, and the latter is problematic is the latter changes the
> display of the buffer while the former changes just the mini-buffer.
So it sounds like you'd indeed be happy with an input-event-hook.
> The other possibility is not to have an interaction hook but to have a
> "the buffer has just changed in some way that is liable to cause a
> redisplay"-hook. I don't know that this would be better. I throw it out
> as a possibility, depending on which is easier.
Then maybe the (new in 24.4) pre-redisplay-function could be used
for that. Something like
(add-function :before pre-redisplay-function
(lambda (wins)
(if (or (eq t wins)
(memq <mybuffer> (mapcar #'window-buffer wins)))
<take-foo-down>)))
Of course, this will require some care, since a redisplay happens
probably right after you've set things up (i.e. before you start
waiting for user input), and you don't want *that* redisplay to trigger
the <take-foo-down>.
Stefan
next prev parent reply other threads:[~2015-02-09 16:13 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-05 13:28 pre-command-hook with input methods Phillip Lord
2015-02-05 20:19 ` Stefan Monnier
2015-02-06 13:55 ` Phillip Lord
2015-02-06 15:17 ` Stefan Monnier
2015-02-06 15:45 ` Phillip Lord
2015-02-06 23:58 ` Stefan Monnier
2015-02-09 10:47 ` Phillip Lord
2015-02-09 14:41 ` Stefan Monnier
2015-02-09 15:30 ` Phillip Lord
2015-02-09 16:13 ` Stefan Monnier [this message]
2015-02-10 14:09 ` Phillip Lord
2015-02-11 17:17 ` Phillip Lord
2015-02-11 19:21 ` Stefan Monnier
2015-02-12 10:27 ` Phillip Lord
2015-05-25 22:52 ` Stefan Monnier
2015-05-27 16:03 ` Phillip Lord
2015-05-27 19:45 ` Stefan Monnier
2015-05-27 21:54 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy4o7rrx2.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=phillip.lord@newcastle.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.