From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 0245cc3: Improve accessibility of window dividers. (Bug#20183) Date: Thu, 02 Jul 2015 09:55:49 -0400 Message-ID: References: <20150702070503.30720.41171@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1435845387 25803 80.91.229.3 (2 Jul 2015 13:56:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 2 Jul 2015 13:56:27 +0000 (UTC) Cc: Martin Rudalics To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 02 15:56:19 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZAeyQ-0006GU-SB for ged-emacs-devel@m.gmane.org; Thu, 02 Jul 2015 15:56:19 +0200 Original-Received: from localhost ([::1]:36708 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAeyQ-0006Jn-7G for ged-emacs-devel@m.gmane.org; Thu, 02 Jul 2015 09:56:18 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAey2-0006Fi-VP for emacs-devel@gnu.org; Thu, 02 Jul 2015 09:55:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZAexz-0002y6-M5 for emacs-devel@gnu.org; Thu, 02 Jul 2015 09:55:54 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:42746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZAexz-0002y0-4J for emacs-devel@gnu.org; Thu, 02 Jul 2015 09:55:51 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0A9FgA731xV/2cGNJ1cgxCEAoVVwwsEAgKBPD0QAQEBAQEBAYEKQQWDXQEBBFYjEAs0EhQYDYhjzyMBAQEBBgEBAQEeizqFBQcWhBcFqmGKIyOCO4FZIoJ4AQEB X-IPAS-Result: A0A9FgA731xV/2cGNJ1cgxCEAoVVwwsEAgKBPD0QAQEBAQEBAYEKQQWDXQEBBFYjEAs0EhQYDYhjzyMBAQEBBgEBAQEeizqFBQcWhBcFqmGKIyOCO4FZIoJ4AQEB X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="129050796" Original-Received: from 157-52-6-103.cpe.teksavvy.com (HELO pastel.home) ([157.52.6.103]) by ironport2-out.teksavvy.com with ESMTP; 02 Jul 2015 09:55:50 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id A2E6E6165D; Thu, 2 Jul 2015 09:55:49 -0400 (EDT) In-Reply-To: (Martin Rudalics's message of "Thu, 02 Jul 2015 07:05:04 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187711 Archived-At: > +(defgroup window-divider nil [...] > +(defcustom window-divider-mode nil [..] > + :group 'window-divider This :group is redundant since it refers to the last created group. > +(define-minor-mode window-divider-mode [...] > + :group 'window-divider > + :global t > + :variable (window-divider-mode > + . (lambda (value) > + (frame--window-divider-mode-set-and-apply > + (and value > + (or frame--window-divider-previous-mode > + (default-value 'window-divider-mode) > + 'right-only)))))) I'd rather not abuse the (GETTER . SETTER) here. This is only really needed for those cases where the value of the mode is neither kept in a global var nor a buffer-local var (e.g. it's kept in a window or frame parameter instead). So, we should drop :variable, which will also let us drop the separate defcustom. Stefan