From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] master b8a46cb: Add support to build packages from Emacs repo Date: Thu, 10 Sep 2015 11:06:40 -0400 Message-ID: References: <20150909212722.11433.8128@vcs.savannah.gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441897762 19437 80.91.229.3 (10 Sep 2015 15:09:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 10 Sep 2015 15:09:22 +0000 (UTC) Cc: =?windows-1252?Q?Fabi=E1n?= Ezequiel Gallina To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 10 17:09:13 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Za3R5-0005Au-2L for ged-emacs-devel@m.gmane.org; Thu, 10 Sep 2015 17:06:51 +0200 Original-Received: from localhost ([::1]:49724 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za3R4-0003vV-Ou for ged-emacs-devel@m.gmane.org; Thu, 10 Sep 2015 11:06:50 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40804) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za3R1-0003vM-EW for emacs-devel@gnu.org; Thu, 10 Sep 2015 11:06:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Za3Qw-0003Hf-FJ for emacs-devel@gnu.org; Thu, 10 Sep 2015 11:06:47 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:57494) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Za3Qw-0003H1-Al; Thu, 10 Sep 2015 11:06:42 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0ArEwA731xV/+uZpUVcgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBBFYjEAs0EhQYDYhjzyMBAQEBBgIBH4s6hQUHFoQXBZksQZlSgUUjhBQigngBAQE X-IPAS-Result: A0ArEwA731xV/+uZpUVcgxCEAoVVuzcJh0sEAgKBPDkUAQEBAQEBAYEKQQWDXQEBBFYjEAs0EhQYDYhjzyMBAQEBBgIBH4s6hQUHFoQXBZksQZlSgUUjhBQigngBAQE X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="164450196" Original-Received: from 69-165-153-235.dsl.teksavvy.com (HELO ceviche.home) ([69.165.153.235]) by ironport2-out.teksavvy.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 10 Sep 2015 11:06:41 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 8918B661D2; Thu, 10 Sep 2015 11:06:40 -0400 (EDT) In-Reply-To: (Fabi's message of "Wed, 09 Sep 2015 21:27:23 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:189801 Archived-At: > +(defun archive--core-package-sync (definition) Trying it out, I see a problem: this shouldn't constantly copy the files. I think it should instead do one of (by order of preference): - use symlinks - use hardlinks - check the contents and only copy it if changed. It's important that when nothing has changed, re-running the "sync externals" doesn't touch anything. Also, I'm not sure we need the support for :excludes, so I think it's OK to drop it (which would let us symlink directly to directories). Stefan