From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: RCS, again: another removed functionality: undo last-checkin Date: Wed, 23 Sep 2015 09:26:56 -0400 Message-ID: References: <87oagx6tzz.fsf@mat.ucm.es> <55FF4026.2050004@yandex.ru> <83si68nu4i.fsf@gnu.org> <87eghsfd3m.fsf@fencepost.gnu.org> <83k2rknr2c.fsf@gnu.org> <87mvwellmg.fsf@uwakimon.sk.tsukuba.ac.jp> <56023A6C.3020302@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1443014848 7591 80.91.229.3 (23 Sep 2015 13:27:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 23 Sep 2015 13:27:28 +0000 (UTC) Cc: "Stephen J. Turnbull" , dak@gnu.org, eliz@gnu.org, rms@gnu.org, emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Sep 23 15:27:19 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zek4r-0004oi-Hp for ged-emacs-devel@m.gmane.org; Wed, 23 Sep 2015 15:27:17 +0200 Original-Received: from localhost ([::1]:47823 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zek4q-00064Y-LH for ged-emacs-devel@m.gmane.org; Wed, 23 Sep 2015 09:27:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38171) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zek4e-00064L-UJ for emacs-devel@gnu.org; Wed, 23 Sep 2015 09:27:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zek4e-0008R5-2F for emacs-devel@gnu.org; Wed, 23 Sep 2015 09:27:04 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:43527) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zek4Y-0008Of-Rq; Wed, 23 Sep 2015 09:26:58 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CVDQA731xV/2yixEVcgxCEAsEVh0sEAgKBPDoTAQEBAQEBAYEKQQWDXQEBAwFWIwULCw4mEhQYDSSINwjPIwEBAQEGAgEfizqFBQeELQWzP4FFI2GDMyKCeAEBAQ X-IPAS-Result: A0CVDQA731xV/2yixEVcgxCEAsEVh0sEAgKBPDoTAQEBAQEBAYEKQQWDXQEBAwFWIwULCw4mEhQYDSSINwjPIwEBAQEGAgEfizqFBQeELQWzP4FFI2GDMyKCeAEBAQ X-IronPort-AV: E=Sophos;i="5.13,465,1427774400"; d="scan'208";a="165634817" Original-Received: from 69-196-162-108.dsl.teksavvy.com (HELO pastel.home) ([69.196.162.108]) by ironport2-out.teksavvy.com with ESMTP; 23 Sep 2015 09:26:56 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id DB48161765; Wed, 23 Sep 2015 09:26:56 -0400 (EDT) In-Reply-To: <56023A6C.3020302@yandex.ru> (Dmitry Gutov's message of "Wed, 23 Sep 2015 08:36:44 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190282 Archived-At: > Maybe we should have both "rollback" and "revert" commands. Multiple > backends seem to distinguish them already. They are indeed very different, so it makes a lot of sense to have them as completely separate commands. The "revert" (which IIUC just installs a new change which undoes the effect of some earlier change) can mostly be implemented in a backend-independent way. But the "rollback" (which IIUC can destructively remove an previous existing commit, I guess I'd call it "uncommit") is a lot more problematic, since various backends support it in very different ways with very different limitations. Generalizing the "Amend:" support of vc-git.el to other backends would probably cover 99% of the use cases. If you feel it's really important that user be able to delete a revision from within Emacs, why not provide a vc-rcs-delete-commits command in vc-rcs.el? That would be a lot simpler to implement and wouldn't force us to come up with some weird pseudo-generic functionality that might end up not even supporting 100% of RCS's use cases. Stefan