From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Anders Lindgren <andlind@gmail.com>
Cc: 21701@debbugs.gnu.org
Subject: bug#21701: Fwd: cl-typecase broken (was 25.0.50; ert explainer for equal can't handle negative numbers)
Date: Fri, 04 Dec 2015 13:17:16 -0500 [thread overview]
Message-ID: <jwvy4dam6q8.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <jwv4mfynmoh.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Fri, 04 Dec 2015 12:36:55 -0500")
> That's indeed what should be done if ERT needs this to be a plain
> character that can inserted in a string. Common-Lisp's `character'
> includes not just characters but also "characters with modifiers" such
> as ?\M-\H-é, which can't appear in a string and are rejected by
> `characterp'.
I installed a patch which makes ERT use pcase over cl-typecase.
In most cases it doesn't make a big difference, but in a few spots, it
is cleaner because a subsequent cl-destructuring-bind can be merged into
it (and it got rid of those places where we used (member :foo)
as a type to just check equality, which is rather inefficient).
Stefan
next prev parent reply other threads:[~2015-12-04 18:17 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-18 8:56 bug#21701: 25.0.50; ert explainer for equal can't handle negative numbers (work in 24.5) Anders Lindgren
2015-12-04 9:41 ` bug#21701: cl-typecase broken (was 25.0.50; ert explainer for equal can't handle negative numbers) Anders Lindgren
[not found] ` <CABr8ebZdsbyLDjayLSXRDqhvyGSTngfdLcKruwavYHmG_MPpWA@mail.gmail.com>
2015-12-04 13:30 ` bug#21701: Fwd: " Stefan Monnier
2015-12-04 15:41 ` Anders Lindgren
2015-12-04 17:36 ` Stefan Monnier
2015-12-04 18:17 ` Stefan Monnier [this message]
2015-12-04 19:42 ` Anders Lindgren
2015-12-04 21:08 ` Drew Adams
2015-12-04 21:25 ` Stefan Monnier
2015-12-04 21:32 ` Drew Adams
2015-12-04 22:58 ` Glenn Morris
2015-12-05 15:08 ` Anders Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy4dam6q8.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=21701@debbugs.gnu.org \
--cc=andlind@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.