From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Code reviews (was: Is it time to drop ChangeLogs?) Date: Mon, 07 Mar 2016 22:25:12 -0500 Message-ID: References: <56BE7E37.3090708@cs.ucla.edu> <4hd1rw1ubr.fsf@fencepost.gnu.org> <83vb50wxhv.fsf@gnu.org> <87y49vz4cg.fsf@acer.localhost.com> <87vb4zb0i4.fsf@gnu.org> <837fheuu6a.fsf@gnu.org> <877fheb1rh.fsf@wanadoo.es> <87ziua9mwq.fsf@wanadoo.es> <83h9git36k.fsf@gnu.org> <87vb4y9ep9.fsf@wanadoo.es> <83a8mat2aa.fsf@gnu.org> <87r3fm9du0.fsf@wanadoo.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1457407566 29498 80.91.229.3 (8 Mar 2016 03:26:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 8 Mar 2016 03:26:06 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 08 04:25:57 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ad8HT-0003g1-Ag for ged-emacs-devel@m.gmane.org; Tue, 08 Mar 2016 04:25:55 +0100 Original-Received: from localhost ([::1]:59899 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad8HS-0002PK-Ce for ged-emacs-devel@m.gmane.org; Mon, 07 Mar 2016 22:25:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40323) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad8Gz-0002Lw-CS for emacs-devel@gnu.org; Mon, 07 Mar 2016 22:25:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ad8Gw-0007IF-62 for emacs-devel@gnu.org; Mon, 07 Mar 2016 22:25:25 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:59241) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ad8Gv-0007IB-Vj for emacs-devel@gnu.org; Mon, 07 Mar 2016 22:25:22 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1ad8Gs-0003Dr-Qq for emacs-devel@gnu.org; Tue, 08 Mar 2016 04:25:18 +0100 Original-Received: from 157.52.15.125 ([157.52.15.125]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 08 Mar 2016 04:25:18 +0100 Original-Received: from monnier by 157.52.15.125 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 08 Mar 2016 04:25:18 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 26 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: 157.52.15.125 User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cancel-Lock: sha1:2n1deTl96hjxc3tXO7NoOyOT+Mc= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:201107 Archived-At: > Introduce code reviews. Don't give commit access to the "golden" > branches to everyone, just to a few top contributors and reviewers. We already have a fair bit of patches submitted and lingering in limbo forever until someone (almost always the same someone, BTW) finally loses hope that some of the other contributors take care of it. If we could switch to a system where every patch is reviewed before commit, that'd be great. My own impression is that it will kill the development pace because too few people are willing to spend the corresponding efforts. That's why I've followed a practice of giving out write access very liberally, with "post-commit spot-check reviews" instead. Indeed, it means that errors in commit messages can't be fixed (we can fix them in the ChangeLog files, admittedly, but since I don't use them it doesn't help me). Maybe we could have a half-way system, where commits are pushed to a branch that is "not fast-forward-only", and this branch is then auto-merged to the real (fast-forward-only) master branch after a delay (one day, maybe?) to give time to fix mess ups before they're cast in stone. Stefan