From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#23357: [PATCH] Don't let `css--property-values' return duplicates Date: Sun, 24 Apr 2016 10:51:06 -0400 Message-ID: References: <1461502642.5416.1@smtp.gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1461509542 23826 80.91.229.3 (24 Apr 2016 14:52:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 24 Apr 2016 14:52:22 +0000 (UTC) Cc: 23357@debbugs.gnu.org, dgutov@yandex.ru To: Simen =?UTF-8?Q?Heggest=C3=B8yl?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 24 16:52:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1auLOL-0007qf-PD for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Apr 2016 16:52:09 +0200 Original-Received: from localhost ([::1]:55669 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auLOL-0002OW-39 for geb-bug-gnu-emacs@m.gmane.org; Sun, 24 Apr 2016 10:52:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49946) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auLOH-0002Mj-SF for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 10:52:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auLOE-0003PK-Ls for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 10:52:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:32795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auLOE-0003PG-Ij for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 10:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1auLOE-0005AT-Bb for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 10:52:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Apr 2016 14:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23357 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org, Dmitry Gutov Original-Received: via spool by submit@debbugs.gnu.org id=B.146150948419813 (code B ref -1); Sun, 24 Apr 2016 14:52:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Apr 2016 14:51:24 +0000 Original-Received: from localhost ([127.0.0.1]:45132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auLNc-00059V-96 for submit@debbugs.gnu.org; Sun, 24 Apr 2016 10:51:24 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1auLNb-00059K-0g for submit@debbugs.gnu.org; Sun, 24 Apr 2016 10:51:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auLNU-0003Hg-UH for submit@debbugs.gnu.org; Sun, 24 Apr 2016 10:51:17 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:49511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auLNU-0003Hc-RD for submit@debbugs.gnu.org; Sun, 24 Apr 2016 10:51:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49835) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auLNU-00019x-41 for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 10:51:16 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1auLNQ-0003HI-Mv for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 10:51:16 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:37483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1auLNQ-0003H5-I9 for bug-gnu-emacs@gnu.org; Sun, 24 Apr 2016 10:51:12 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.7) with ESMTP id u3OEoh2w017255; Sun, 24 Apr 2016 10:50:43 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 0D4CDAE971; Sun, 24 Apr 2016 10:51:07 -0400 (EDT) In-Reply-To: <1461502642.5416.1@smtp.gmail.com> ("Simen =?UTF-8?Q?Heggest=C3=B8yl?="'s message of "Sun, 24 Apr 2016 14:57:22 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5652=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5652> : inlines <4712> : streams <1624573> : uri <2195515> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116759 Archived-At: > By a recent discussion on emacs-devel I was made aware that > completion-at-point functions are themselves responsible for removing > duplicate entries in their results. No they're not. It's the UI code (the code that calls completion-at-point-function) which is responsible for the removal of duplicates. This said, removal of duplicates within the completion table, like your patch does, is harmless, so this is not an objection against your patch. Stefan