all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: "Simen Heggestøyl" <simenheg@gmail.com>
Cc: 23357@debbugs.gnu.org, dgutov@yandex.ru
Subject: bug#23357: [PATCH] Don't let `css--property-values' return duplicates
Date: Sun, 24 Apr 2016 10:51:06 -0400	[thread overview]
Message-ID: <jwvy483ukov.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <1461502642.5416.1@smtp.gmail.com> ("Simen Heggestøyl"'s message of "Sun, 24 Apr 2016 14:57:22 +0200")

> By a recent discussion on emacs-devel I was made aware that
> completion-at-point functions are themselves responsible for removing
> duplicate entries in their results.

No they're not.  It's the UI code (the code that calls
completion-at-point-function) which is responsible for the removal
of duplicates.

This said, removal of duplicates within the completion table, like your
patch does, is harmless, so this is not an objection against your patch.


        Stefan





  reply	other threads:[~2016-04-24 14:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-04-24 12:57 bug#23357: [PATCH] Don't let `css--property-values' return duplicates Simen Heggestøyl
2016-04-24 14:51 ` Stefan Monnier [this message]
2016-04-24 18:04   ` Simen Heggestøyl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvy483ukov.fsf-monnier+emacsbugs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=23357@debbugs.gnu.org \
    --cc=dgutov@yandex.ru \
    --cc=simenheg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.