all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: Compilation warnings in mouse.el
Date: Wed, 13 Jul 2016 08:45:34 -0400	[thread overview]
Message-ID: <jwvy455ww67.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 87bn21nayo.fsf@fastmail.fm

EZ> Unlike Stefan, I think we should add :group to every defcustom. Having
EZ> them mysteriously missing from some of them is a time bomb: 
>> The way I see it, defcustoms should pretty much never have :group, and
>> the group to which they belong is simply determined by the file in which
>> they occur.
> That would mean that in multifile packages the defcustoms must always be
> put in one single file,

Notice I said "pretty much".  Obviously, there will be exceptions, so
we do want to keep the :group for those situations.

> which must be named according to the customisation group one wants to
> create.  And creating multiple customisaton groups for a single package
> (not uncommon in larger packages) would require multiple files.

The current system (default to the last group defined in the current
file) lets you define several groups along with their defcustoms in
a single file without the use of :group.

> That's to say, such a system would require that the code of a package be
> organised along the lines of the customisation groups it provides.  But
> customisation is a UI feature, and as such does not necessarily present
> the best way to organise the code.

Agreed.  But in practice the most common situation is to have the
defgroup in the same file as the corresponding defcustoms.

Maybe a bit less so in multi-file packages (especially less so in
*small* multi-file packages, I think).


        Stefan




  reply	other threads:[~2016-07-13 12:45 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-11 14:23 Compilation warnings in mouse.el Eli Zaretskii
2016-07-11 21:55 ` Stephen Berman
2016-07-12  5:04   ` Eli Zaretskii
2016-07-12  8:45     ` Stephen Berman
2016-07-12 22:40     ` John Wiegley
2016-07-12 22:58       ` Stefan Monnier
2016-07-13  9:28         ` Joost Kremers
2016-07-13 12:45           ` Stefan Monnier [this message]
2016-07-13 14:08             ` Drew Adams
2016-07-13 14:31         ` Eli Zaretskii
2016-07-13 15:12           ` Stefan Monnier
2016-07-13 15:22             ` Drew Adams
2016-07-13 15:37               ` Stefan Monnier
2016-07-13 16:07                 ` Drew Adams
2016-07-13 15:36             ` Eli Zaretskii
2016-07-13 15:42               ` Stefan Monnier
2016-07-13 16:07                 ` Drew Adams
2016-07-13 16:13                 ` Eli Zaretskii
2016-07-13 16:42                   ` Stefan Monnier
2016-07-12 22:56     ` Dmitry Gutov
2016-07-13 14:30       ` Eli Zaretskii
2016-07-13 14:41         ` Dmitry Gutov
     [not found] <<8360scdzik.fsf@gnu.org>
     [not found] ` <<87zipnzvo4.fsf@gmx.net>
     [not found]   ` <<8337nfcupy.fsf@gnu.org>
2016-07-12 14:04     ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvy455ww67.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.