From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 ee04aed: Fix handling of buffer relocation in regex.c functions Date: Mon, 24 Oct 2016 15:01:06 -0400 Message-ID: References: <20161023191028.10942.12099@vcs.savannah.gnu.org> <20161023191028.C103F220124@vcs.savannah.gnu.org> <83mvhu5kn0.fsf@gnu.org> <8360oh4tnt.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1477335779 27771 195.159.176.226 (24 Oct 2016 19:02:59 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 24 Oct 2016 19:02:59 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Oct 24 21:02:53 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bykW3-0004QJ-34 for ged-emacs-devel@m.gmane.org; Mon, 24 Oct 2016 21:02:35 +0200 Original-Received: from localhost ([::1]:49044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bykW5-0007DP-90 for ged-emacs-devel@m.gmane.org; Mon, 24 Oct 2016 15:02:37 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bykUh-0007AG-BG for emacs-devel@gnu.org; Mon, 24 Oct 2016 15:01:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bykUd-0003SP-Dm for emacs-devel@gnu.org; Mon, 24 Oct 2016 15:01:11 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:44119) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bykUd-0003SC-9X; Mon, 24 Oct 2016 15:01:07 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id u9OJ16ho020764; Mon, 24 Oct 2016 15:01:06 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 70D2E6047D; Mon, 24 Oct 2016 15:01:06 -0400 (EDT) In-Reply-To: <8360oh4tnt.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 Oct 2016 19:07:50 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV5837=0 X-NAI-Spam-Version: 2.3.0.9418 : core <5837> : inlines <5363> : streams <1717469> : uri <2314037> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:208735 Archived-At: >> > I think we should consider these nits when we finish fixing the bugs >> > due to relocation, >> I think we should not fix those. The constraints imposed by >> a relocating malloc are too difficult to abide to IMO, so we should just >> say no. > It depends on how hard that is. The last one I fixed was very easy. How many of us know the constraints? How many of those know them enough to think about them when making changes? How many of those get the answer right when thinking about those problems? It's a landmine, just like the gcpros were. > More generally, as long as even a single platform we care about uses > ralloc.c, I don't think we can leave those problems unfixed, because > their effects are so nasty. That's why I'm advocating getting rid of it. Stefan