From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Killing frame-locals Date: Wed, 21 Dec 2016 14:27:22 -0500 Message-ID: References: <20161203014504.8507.42564@vcs.savannah.gnu.org> <20161203014505.D8E2D2201C6@vcs.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1482348632 25661 195.159.176.226 (21 Dec 2016 19:30:32 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 21 Dec 2016 19:30:32 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Dec 21 20:30:28 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cJmap-00064g-AK for ged-emacs-devel@m.gmane.org; Wed, 21 Dec 2016 20:30:27 +0100 Original-Received: from localhost ([::1]:58678 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJmat-0004jl-SK for ged-emacs-devel@m.gmane.org; Wed, 21 Dec 2016 14:30:31 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40361) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cJman-0004jV-9p for emacs-devel@gnu.org; Wed, 21 Dec 2016 14:30:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cJmaj-0001Fh-VI for emacs-devel@gnu.org; Wed, 21 Dec 2016 14:30:25 -0500 Original-Received: from [195.159.176.226] (port=52751 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cJmaj-0001FL-Np for emacs-devel@gnu.org; Wed, 21 Dec 2016 14:30:21 -0500 Original-Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1cJmaS-0003QH-6k for emacs-devel@gnu.org; Wed, 21 Dec 2016 20:30:04 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 43 Original-X-Complaints-To: usenet@blaine.gmane.org Cancel-Lock: sha1:XmNij4F4ZwaHVoixXAKP4+F44TI= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 195.159.176.226 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210706 Archived-At: OK, looks like there's no objection, so I'll install the patch. Thanks, Stefan >>>>> "Noam" == Noam Postavsky writes: > On Sat, Dec 17, 2016 at 9:31 AM, Stefan Monnier > wrote: >> Ping? >> >> I'll take care of the patch, if we agree, >> >> >> Stefan >> >> >>>>>>> "Stefan" == Stefan Monnier writes: >> >>>> + else if (sym->redirect == SYMBOL_LOCALIZED >>>> + && SYMBOL_BLV (sym)->frame_local) >>>> + xsignal1 (Qtrapping_frame_local, symbol); >> >>> BTW, make-variable-frame-local has been declared obsolete since >>> Emacs-22.2, so I think now is a good time to get rid of >>> frame-local variables. >> > I did a web search for make-variable-frame-local, I found only > perspective-el still using it. I think it's a fairly popular package; > on the other hand, it's not in GNU ELPA, and it's not like they didn't > have warning in advance... > https://github.com/nex3/perspective-el/blob/1.12/perspective.el#L194-L197 > ;; make-variable-frame-local is obsolete according to the docs, > ;; but I don't want to have to manually munge frame-parameters > ;; all the time so I'm using it anyway. > (make-variable-frame-local