From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: emacs-devel@gnu.org
Cc: Ken Raeburn <raeburn@raeburn.org>
Subject: Re: [Emacs-diffs] master 064701d 2/3: Increase the obarray size.
Date: Sat, 31 Dec 2016 09:18:24 -0500 [thread overview]
Message-ID: <jwvy3yw5glf.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <20161230230257.E6F992201CD@vcs.savannah.gnu.org> (Ken Raeburn's message of "Fri, 30 Dec 2016 23:02:57 +0000 (UTC)")
> In a typical GNU/Linux/X11 build, we wind up with over 15k symbols by
> the time we've started. The old obarray size ensured an average chain
> length of 10 or more.
> * src/lread.c (OBARRAY_SIZE): Increase to 15121.
Have you checked the performance impact? E.g. compared to a length of 8K?
I do believe 15K is better than 1.5K, but an average length of 1 sound
like the hash array might end up being larger than the optimal size.
Stefan
next parent reply other threads:[~2016-12-31 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20161230230257.13334.59525@vcs.savannah.gnu.org>
[not found] ` <20161230230257.E6F992201CD@vcs.savannah.gnu.org>
2016-12-31 14:18 ` Stefan Monnier [this message]
2016-12-31 20:54 ` [Emacs-diffs] master 064701d 2/3: Increase the obarray size Ken Raeburn
2017-01-01 14:43 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy3yw5glf.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=raeburn@raeburn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.