From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: martin rudalics <rudalics@gmx.at>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Emacs-26.0.91: switch-to-buffer-other-window runs too slowly (about 0.1s)
Date: Mon, 26 Mar 2018 16:09:07 -0400 [thread overview]
Message-ID: <jwvy3ieeh8c.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <5AB94021.8080700@gmx.at> (martin rudalics's message of "Mon, 26 Mar 2018 20:46:57 +0200")
>> But I think in the case where we move from window A to window B and both
>> are on the same frame we should either not call
>> window--maybe-raise-frame or else that function should do nothing in
>> that case. Basically, I feel like if the movement is intra-frame than
>> no frame-level operations should be involved.
> There's no guarantee that the selected frame is visible at the time
> `display-buffer' is called.
If we're already on the destination frame, then I'd argue that if that
frame is not visible it's a pre-existing condition and there's no
particular reason to "fix" it at that time.
IOW I think that in window--maybe-raise-frame
;; Assume the selected frame is already visible enough.
(eq frame (selected-frame))
should apply not just to raise-frame but also to make-frame-visible.
Stefan
next prev parent reply other threads:[~2018-03-26 20:09 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-26 10:12 Emacs-26.0.91: switch-to-buffer-other-window runs too slowly (about 0.1s) zhang cc
2018-03-26 15:16 ` Eli Zaretskii
2018-03-26 15:22 ` zhang cc
[not found] ` <544b8346-bda9-45eb-9573-1d51d9f768b2@Spark>
2018-03-26 15:25 ` zhang cc
2018-03-26 15:30 ` Eli Zaretskii
2018-03-26 16:09 ` Robert Pluim
2018-03-26 16:29 ` Clément Pit-Claudel
2018-03-26 16:34 ` Robert Pluim
2018-03-26 16:37 ` Noam Postavsky
2018-03-26 16:59 ` Robert Pluim
2018-03-26 17:28 ` Eli Zaretskii
2018-03-26 17:49 ` Stefan Monnier
2018-03-26 18:17 ` Eli Zaretskii
2018-03-26 18:26 ` Stefan Monnier
2018-03-26 18:33 ` Eli Zaretskii
2018-03-26 18:41 ` Stefan Monnier
2018-03-26 18:46 ` martin rudalics
2018-03-26 18:58 ` Eli Zaretskii
2018-03-26 19:16 ` martin rudalics
2018-03-26 19:24 ` Eli Zaretskii
2018-03-26 21:41 ` martin rudalics
2018-03-27 2:50 ` Eli Zaretskii
2018-03-27 7:23 ` martin rudalics
2018-03-29 9:37 ` Eli Zaretskii
2018-03-29 23:15 ` Noam Postavsky
2018-03-29 23:20 ` Noam Postavsky
2018-03-30 7:51 ` Eli Zaretskii
2018-03-26 20:09 ` Stefan Monnier [this message]
2018-03-26 21:42 ` martin rudalics
2018-03-27 2:45 ` Eli Zaretskii
2018-03-27 3:41 ` Stefan Monnier
2018-03-27 7:23 ` martin rudalics
2018-03-27 12:00 ` Stefan Monnier
2018-03-29 8:58 ` Eli Zaretskii
2018-03-26 18:46 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy3ieeh8c.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.