From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] scratch/so-long 7273fb2: Add so-long library Date: Sat, 12 Jan 2019 16:01:41 -0500 Message-ID: References: <20190107065207.21793.53271@vcs0.savannah.gnu.org> <20190107065208.BA36C21736@vcs0.savannah.gnu.org> <16bb3884-c2de-b178-afe8-0b13a8b116a8@orcon.net.nz> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1547326834 14983 195.159.176.226 (12 Jan 2019 21:00:34 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 12 Jan 2019 21:00:34 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Phil Sainty Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 12 22:00:30 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1giQOM-0003mJ-GR for ged-emacs-devel@m.gmane.org; Sat, 12 Jan 2019 22:00:30 +0100 Original-Received: from localhost ([127.0.0.1]:37788 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giQQT-0006E5-5M for ged-emacs-devel@m.gmane.org; Sat, 12 Jan 2019 16:02:41 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:48139) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giQPc-0006DM-AG for emacs-devel@gnu.org; Sat, 12 Jan 2019 16:01:48 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1giQPb-0004cw-Li for emacs-devel@gnu.org; Sat, 12 Jan 2019 16:01:48 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:49153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1giQPb-0004YE-Ga for emacs-devel@gnu.org; Sat, 12 Jan 2019 16:01:47 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x0CL1fjS032713; Sat, 12 Jan 2019 16:01:42 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id 803AD6A2E9; Sat, 12 Jan 2019 16:01:41 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Sat, 12 Jan 2019 10:11:05 -0500") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6459=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6459> : inlines <6992> : streams <1809898> : uri <2778934> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:232325 Archived-At: >>> On the design side, I think you should merge `so-long` and >>> `so-long-mode` into a single function and make that function >>> a (buffer-local) minor-mode (i.e. not have any major mode, just use >>> fundamental-mode instead). Making it a minor mode rather than >>> a major-mode will also make it easier to remember the previous >>> major-mode without any need for a change-major-mode-hook hack. >> These changes are too significant, so I don't wish to do any of that. > I think they're just some minor shuffling of code. Also, I'm wondering which part you don't like. There are fundamentally two aspects in my suggestion: - merge the two - use a minor mode I think the most important for the user is the first: the difference between M-x so-long RET and M-x so-long-mode RET seems fairly subtle to me and I expect users will have trouble remembering which is which or even understand that they don't do the same. Stefan