From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Opportunistic garbage collection Date: Thu, 25 Apr 2019 08:49:20 -0400 Message-ID: References: <837ebi1twt.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="255728"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Paul Eggert , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 25 14:49:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hJdp0-0014OU-Cs for ged-emacs-devel@m.gmane.org; Thu, 25 Apr 2019 14:49:50 +0200 Original-Received: from localhost ([127.0.0.1]:56642 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJdoz-00089H-9X for ged-emacs-devel@m.gmane.org; Thu, 25 Apr 2019 08:49:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:50520) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJdoo-000885-NM for emacs-devel@gnu.org; Thu, 25 Apr 2019 08:49:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJdom-0003fM-K9 for emacs-devel@gnu.org; Thu, 25 Apr 2019 08:49:38 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:34063) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJdoh-0003b4-3m; Thu, 25 Apr 2019 08:49:32 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.7/8.14.1) with ESMTP id x3PCnKSh014079; Thu, 25 Apr 2019 08:49:20 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 3BEC86AE07; Thu, 25 Apr 2019 08:49:20 -0400 (EDT) In-Reply-To: <837ebi1twt.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 25 Apr 2019 09:27:30 +0300") X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 2 Rules triggered EDT_SA_DN_PASS=0, RV6533=0 X-NAI-Spam-Version: 2.3.0.9418 : core <6533> : inlines <7059> : streams <1819686> : uri <2836898> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235918 Archived-At: >> > /* If there is still no input available, ask for GC. */ >> > if (!detect_input_pending_run_timers (0)) >> > - maybe_gc (); >> > + maybe_gc (); /* FIXME: Why? */ >> > } >> If we don't know why, let's get rid of it.... > We know why, we just think this actually causes GC only very rarely. Indeed, I kept it because I'm not 100% sure I understand it enough to remove it. Stefan