From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#36237: Support (rx (and (regexp EXPR) (regexp-quote EXPR))) Date: Sun, 16 Jun 2019 07:34:49 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="75077"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Michael Heerdegen , 36237@debbugs.gnu.org, Noam Postavsky , kevin.legouguec@gmail.com To: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 16 13:36:16 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hcTSJ-000JMJ-UW for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Jun 2019 13:36:16 +0200 Original-Received: from localhost ([::1]:38970 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcTSI-0000Bg-Ox for geb-bug-gnu-emacs@m.gmane.org; Sun, 16 Jun 2019 07:36:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60822) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcTSA-0000BJ-7n for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2019 07:36:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcTS8-0003H1-BF for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2019 07:36:06 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54593) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcTS6-0003F4-ID for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2019 07:36:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hcTS6-00026G-Cl for bug-gnu-emacs@gnu.org; Sun, 16 Jun 2019 07:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 16 Jun 2019 11:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36237 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 36237-submit@debbugs.gnu.org id=B36237.15606849037984 (code B ref 36237); Sun, 16 Jun 2019 11:36:02 +0000 Original-Received: (at 36237) by debbugs.gnu.org; 16 Jun 2019 11:35:03 +0000 Original-Received: from localhost ([127.0.0.1]:39904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcTR8-00024h-TM for submit@debbugs.gnu.org; Sun, 16 Jun 2019 07:35:03 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:10045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hcTR6-00024A-NP for 36237@debbugs.gnu.org; Sun, 16 Jun 2019 07:35:01 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 363A4443957; Sun, 16 Jun 2019 07:34:54 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E05C54401CA; Sun, 16 Jun 2019 07:34:52 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1560684892; bh=sJc4a+4DE5udg+JfmFD+XFHqpV7ViDS8dg37oLY086A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=IoTRvzDcmOdJSc5nmYU4T+EWGVPua95H9pfOgI2R+68m1Zlv/tNEWWSyDbCTQDevp /ie8/F6xN0DFF388OvNSxgKM1UK2lgoOHLYfEJTJmtJ2cpMQiGhzsH6x7SqRjpYgAX E7qPlmk32IMxE0mjeau8ZAJ2ownD9G6TqeQ6yoFMmToA63BDmvUqO0yBm0t7BsG+J+ Wq/d4knTsRq0A/P0TPlvNWA+Z1NGNfdg9pgWtxHrOe9BwtQkB79QBsAzrCOjgqdd8z fSxaJFjo9MFsk0JWXv3jeGke9MwTFvbo8Pgr9gfK7uICUPIPyjwDchiB43STF9gGXj f1Ffp5/c49SmA== Original-Received: from pastel (unknown [157.52.10.58]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9E993120C60; Sun, 16 Jun 2019 07:34:52 -0400 (EDT) In-Reply-To: ("Mattias \=\?windows-1252\?Q\?Engdeg\=E5rd\=22's\?\= message of "Sun, 16 Jun 2019 12:03:53 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:160662 Archived-At: First, thanks Noam, this is a very welcome improvement. [ BTW, please use "--" for rx-compile-to-lisp since I believe it's internal. ] What do regexp and regexp-quote do in rx-to-string? > - A more suitable name is needed; `regexp-quote' makes no sense at all in > the context of rx. What about `literal'? For simplicity, I'm proceeding with > that name below. I'll let others figure that one out. > - What is now the correct way of including a compile-time regexp expression, > such as a defconst? (regexp (eval-when-compile EXPR))? Still a mouthful, but > perhaps outside the scope of this bug. FWIW, I have the impression that in most cases where this could be useful, a better solution would be to provide something like `rx-defmacro` and/or `rx-macrolet`. Stefan