From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#36803: 27.0.50; Update mode-line of every window when compilation ends Date: Fri, 26 Jul 2019 12:23:26 -0400 Message-ID: References: <877e87i0vw.fsf@gmail.com> <87imrqcuws.fsf@mouse.gnus.org> <83ef2enosr.fsf@gnu.org> <83r26dmcx3.fsf@gnu.org> <83imron88m.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="22210"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: 36803@debbugs.gnu.org, larsi@gnus.org, kevin.legouguec@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 26 18:24:09 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hr30r-0005dO-6E for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2019 18:24:09 +0200 Original-Received: from localhost ([::1]:41720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr30q-0001xe-4U for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Jul 2019 12:24:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40671) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hr30m-0001xQ-UX for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 12:24:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hr30l-0000rB-PI for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 12:24:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34438) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hr30l-0000qM-Le for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 12:24:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hr30k-0005rB-Df for bug-gnu-emacs@gnu.org; Fri, 26 Jul 2019 12:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jul 2019 16:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 36803 X-GNU-PR-Package: emacs Original-Received: via spool by 36803-submit@debbugs.gnu.org id=B36803.156415821922383 (code B ref 36803); Fri, 26 Jul 2019 16:24:02 +0000 Original-Received: (at 36803) by debbugs.gnu.org; 26 Jul 2019 16:23:39 +0000 Original-Received: from localhost ([127.0.0.1]:43259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr30M-0005ow-8E for submit@debbugs.gnu.org; Fri, 26 Jul 2019 12:23:38 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:8917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hr30I-0005oE-WF for 36803@debbugs.gnu.org; Fri, 26 Jul 2019 12:23:36 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 2F507102D83; Fri, 26 Jul 2019 12:23:29 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id C7BD91013C1; Fri, 26 Jul 2019 12:23:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1564158207; bh=DLoQJn4gnQ03Fn3VTacUvsht65K+6Qfn7yU9mSjf0Qk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=bHssGljBPHRE+qOCm8p0hzffK6EFDaf07mB77QauyoykC4YkHf9Q8MwEi2TMrn+Ws DOwt/nxTUo3J/D8Z1Se12SgLecz2oYVHfJJzXcZyFwjIfF8pWnZgv5bkXAFHQMd6xU texTuiBg5lInZPBUC9spvXAcZ0t54xWadnNHSMZhOMNE711FgooyNha8yXWregu7ee 04LKm7KLJqvfuRH+nUH2wchguSI0gfHrtm07s/joF3yAfvc85HYuvq7rB6SxLSvGHT 2Apt2/F8efTBfLc3SE4Ojd3ZY0xpYKBjZRu9jOFoGNRKkHETFk/kr4Bcihi1ON9ukU NrjoS+76uoR8A== Original-Received: from alfajor (modemcable157.163-203-24.mc.videotron.ca [24.203.163.157]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 6AB3F120C71; Fri, 26 Jul 2019 12:23:27 -0400 (EDT) In-Reply-To: <83imron88m.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 26 Jul 2019 18:08:57 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:163805 Archived-At: >> > Stefan, I'm looking and looking, and don't understand why that change >> > made sense. The process-status indication in the mode line is shown >> > in all windows, so status_notify is exactly the place where we should >> > trigger update of all mode lines. >> >> Hmm... AFAIK the "process status" normally only indicates the status of >> the process running in the buffer to which this mode line belongs. >> Which is why I made the change to only bset_update_mode_line rather than >> set the global update_mode_lines. > > So you are saying that there's a redisplay bug, whereby some windows > that display a buffer don't have their mode line updated in the recipe > of this bug report? In the recipe of this bug, we have a process in the compilation buffer and the status of this process is reflected in the mode line of *all* windows (via the compilation-in-progress variable). The "process status" I'm referring to above is another kind of "process status" in the mode-line: that of `mode-line-process` which is usually buffer-local and only reflects the status of the process running in that same buffer. >> Additionally, in this particular case, the need to update all mode-lines >> doesn't come from the fact that a sentinel was run, but from the fact >> that compilation-in-progress was modified, which can (and does) also >> happen when no sentinel is run. So I think TRT is something like the >> patch below. > force-mode-line-update with a non-nil argument affects all the > windows, even those which don't show the process status. So why are > you saying it's TRT in this case? Because the status of the compilation process *is* by default reflected in the mode line of all windows (I disable this in my own config because I don't like it). Stefan