From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Eli Zaretskii <eliz@gnu.org>
Cc: Kenichi Handa <handa@gnu.org>, emacs-devel@gnu.org
Subject: Re: Auto de-composition when point is inside a composition
Date: Mon, 21 Oct 2019 14:43:32 -0400 [thread overview]
Message-ID: <jwvy2xeq6xx.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <835zki2ic9.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 21 Oct 2019 19:07:02 +0300")
>> - why do we need to set windows_or_buffers_changed at all here?
>> after all, this code is only run in some circumstances, definitely not
>> all the circumstances where we might need to redraw the grapheme
>> cluster after point moved out of it, so it seems it's not the right
>> place to handle this case (it seems either redundant or insufficient).
>
> Maybe because otherwise the redisplay optimizations taken in case only
> point moved could fail to redisplay (they might only redraw the
> character at point, and fail to include the rest of the composition)?
But in that case, if the command that moved point set
disable-point-adjustment to non-nil, we'd have a redisplay error, no
(since we'd then skip this chunk of code).
Stefan
next prev parent reply other threads:[~2019-10-21 18:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-21 14:15 Auto de-composition when point is inside a composition Stefan Monnier
2019-10-21 16:07 ` Eli Zaretskii
2019-10-21 18:43 ` Stefan Monnier [this message]
2019-10-21 19:08 ` Stefan Monnier
2019-10-22 14:52 ` Eli Zaretskii
2019-10-22 14:54 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy2xeq6xx.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=handa@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.