From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/2] Add module functions to convert from and to big integers. Date: Sun, 03 Nov 2019 14:38:47 -0500 Message-ID: References: <20190423131742.65814-1-phst@google.com> <20190423131742.65814-2-phst@google.com> <102dc3dc-554c-a55e-ae7c-cc7357ee60f5@cs.ucla.edu> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="24125"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Philipp Stephani , Paul Eggert , Emacs developers To: Philipp Stephani Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Nov 03 20:40:00 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iRLjB-00062i-C9 for ged-emacs-devel@m.gmane.org; Sun, 03 Nov 2019 20:39:57 +0100 Original-Received: from localhost ([::1]:55834 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRLjA-00011L-6t for ged-emacs-devel@m.gmane.org; Sun, 03 Nov 2019 14:39:56 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44734) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iRLiA-0000nR-0t for emacs-devel@gnu.org; Sun, 03 Nov 2019 14:38:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iRLi8-0001Zx-NJ for emacs-devel@gnu.org; Sun, 03 Nov 2019 14:38:53 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:63189) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1iRLi8-0001YS-Gi for emacs-devel@gnu.org; Sun, 03 Nov 2019 14:38:52 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id E696810064F; Sun, 3 Nov 2019 14:38:49 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id B69741005F7; Sun, 3 Nov 2019 14:38:48 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1572809928; bh=GR9t8WLZkNPc2eR2UYBwETyNTd23FcVLbAwH+v4ht+4=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=It1ioslUPv2k2CSXkBRhTg9XVkN+6i7TkwfSc4qalvV0nhOcNboo8QqVb2tIRqIdh aCdRi+g5yXE5uOAGFU8n7OSM66eDd7fj03B93JIgNhYvRILya9Yx1eSUhkNh2r/gzn xf+JnGYFdP/IB6t3o+y/sapPJMQtQC7/ZbZoLzj5ocPlhrmdUHX8HPZ0Z7f8ooLzn5 TlluIHupVHpCA4ocwQy+7W4YL5zoqqDmmdz6wAhm8Encw3CzPMapO5MSeS3q+Da4I4 P4kFK8qaTfQhHmKBYR9+ggNTozcfwChB0EHXVzwIb6Nw56Y7qekdfGBbXKWLUUyMXE +gLX/KDdtfGbA== Original-Received: from alfajor (unknown [45.72.173.20]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 5AE971204E9; Sun, 3 Nov 2019 14:38:48 -0500 (EST) In-Reply-To: (Philipp Stephani's message of "Sat, 2 Nov 2019 20:17:39 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:241755 Archived-At: > Overall I now think the original approach (without mpz_t) is quite > superior, and unless I hear convincing counterarguments, I'll send a > patch to revert to that. FWIW, I agree. The main argument for me is the fact that it exposes an internal implementation detail whereas the module interface makes a lot of effort to hide all implementation details (even the representation of Lisp_Object!). Stefan