From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master f225011: ibuffer-do-isearch: don't depend on `cl-values-list' (bug#38430) Date: Sun, 01 Dec 2019 13:29:22 -0500 Message-ID: References: <20191201091356.26612.95511@vcs0.savannah.gnu.org> <20191201091358.11752207E0@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="24868"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: Juanma Barranquero To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Dec 01 19:29:44 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1ibTyY-0006GF-6j for ged-emacs-devel@m.gmane.org; Sun, 01 Dec 2019 19:29:42 +0100 Original-Received: from localhost ([::1]:54196 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibTyW-000262-LJ for ged-emacs-devel@m.gmane.org; Sun, 01 Dec 2019 13:29:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57025) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ibTyK-00025f-2L for emacs-devel@gnu.org; Sun, 01 Dec 2019 13:29:29 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ibTyJ-0003pv-28 for emacs-devel@gnu.org; Sun, 01 Dec 2019 13:29:27 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:34730) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ibTyI-0003ph-UK for emacs-devel@gnu.org; Sun, 01 Dec 2019 13:29:27 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6FF7144A4E1; Sun, 1 Dec 2019 13:29:26 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 33D9644A4C1; Sun, 1 Dec 2019 13:29:25 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1575224965; bh=VSw8F80A5Tw15OaVuQw0xtBHa7y/oBVoFa3wchaAItU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=kvXg6KvN+cCRrCHeCqgQh3bZhkhisyYOp76lknfmHQShkI16YC+ah4GnQKKvIyZgX D9kCrksiKtKZ5vYLgXcHiSvtcimBqWyORF2N/NsZ+hHEAKMdZqth47WpVTiT7pNFwg uiD3JRjSARTP3qg4VwNQoXECKyEOQtchj46kb8onWa9+pPKQ/iFri2rXPlieJaTDYJ Sek6vXBS46XLSuHyF3CgaNaNyNZ1AUks7ORvSgUzhbcMX9HX6mVG3h2c5/pur9xiV2 sFtuUeaMmJZuB6qGis9ef6bE+9L2lEaQ/vhx+4uuc4yy5hRuehOWBiratuDkVS88tT J6ZwMn2gE6+iQ== Original-Received: from pastel (unknown [45.72.134.213]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E89FF12121B; Sun, 1 Dec 2019 13:29:24 -0500 (EST) In-Reply-To: <20191201091358.11752207E0@vcs0.savannah.gnu.org> (Juanma Barranquero's message of "Sun, 1 Dec 2019 04:13:57 -0500 (EST)") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:242966 Archived-At: > (cl-multiple-value-bind (hip-crowd lamers) > - (cl-values-list > - (ibuffer-split-list (lambda (bufmark) > - (ibuffer-included-in-filters-p (car bufmark) > - filterset)) > - bmarklist)) > + (ibuffer-split-list (lambda (bufmark) > + (ibuffer-included-in-filters-p (car bufmark) > + filterset)) > + bmarklist) This is "broken" in the sense that it makes assumptions about how the "multiple values" are implemented. We do know that `ibuffer-split-list` returns a list, so there's no point going through CL's multiple-values simulation. We should instead treat it as a list and extract the elements with `pcase-let` (or `cl-destructuring-bind`). Stefan