From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 2ab66c9: Replace project-kill-buffers-ignores with project-kill-buffer-conditions Date: Tue, 28 Jul 2020 19:10:34 -0400 Message-ID: References: <20200728222419.2111.71622@vcs0.savannah.gnu.org> <20200728222420.F3D25209DF@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32085"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Philip K Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Jul 29 01:11:36 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k0Yky-0008G0-GL for ged-emacs-devel@m.gmane-mx.org; Wed, 29 Jul 2020 01:11:36 +0200 Original-Received: from localhost ([::1]:55720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1k0Ykx-00008S-CL for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Jul 2020 19:11:35 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:41876) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0YkC-00089g-P4 for emacs-devel@gnu.org; Tue, 28 Jul 2020 19:10:49 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:50700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1k0Yk7-0004Qb-PB for emacs-devel@gnu.org; Tue, 28 Jul 2020 19:10:47 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7226781A2A; Tue, 28 Jul 2020 19:10:42 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CA53F80C96; Tue, 28 Jul 2020 19:10:40 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1595977840; bh=mLY6KO0Fbz9B0UaMPYELTjtUOPqzXd7vR5wnBpTGKD0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Jxd+bstF8AX7PCePcpf9YxnSY12PvPaEa16uS/99zqlTohohMDH+5gnJhbuAbFt6+ +3ZaDZ2x7InsV1JTeDwLXy1m+s7GCpfK2Kh0Wy6ev5XS/8XxSKfcUlg/CftBZMI6ga RDf2TngWgTb+1gHG6OC6h8SDHRDFNmVuJC7jgLM+79QLF82qSI3cI5AG2hTI6l2Wsa SALR+Nt3rlDOehB0b7bZKKvhOHJwNGut6lMTdJKPPNcF5kajNH3g2+RRmkP8Q+lorg na5nyV1jP9GUMyZ7pgS3girbPDjp2zFMkrf3OcmZJ25Bc/RPU/NTNCvNLySNxc1tlj 6bTE/kO73Ah0Q== Original-Received: from milanesa (unknown [104.247.229.155]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A5F9912089B; Tue, 28 Jul 2020 19:10:40 -0400 (EDT) In-Reply-To: <20200728222420.F3D25209DF@vcs0.savannah.gnu.org> (Dmitry Gutov's message of "Tue, 28 Jul 2020 18:24:20 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/07/28 19:10:42 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:253318 Archived-At: > +(defun project--kill-buffer-check (buf conditions) > + "Check if buffer BUF matches any element of the list CONDITIONS. > +See `project-kill-buffer-conditions' for more details on the form > +of CONDITIONS." > + (catch 'kill > + (dolist (c conditions) > + (when (cond > + ((stringp c) > + (string-match-p c (buffer-name buf))) > + ((symbolp c) > + (funcall c buf)) > + ((eq (car-safe c) 'major-mode) > + (eq (buffer-local-value 'major-mode buf) > + (cdr c))) > + ((eq (car-safe c) 'derived-mode) > + (provided-mode-derived-p > + (buffer-local-value 'major-mode buf) > + (cdr c))) > + ((eq (car-safe c) 'not) > + (not (project--kill-buffer-check buf (cdr c)))) > + ((eq (car-safe c) 'or) > + (project--kill-buffer-check buf (cdr c))) > + ((eq (car-safe c) 'and) > + (seq-every-p > + (apply-partially #'project--kill-buffer-check > + buf) > + (mapcar #'list (cdr c))))) > + (throw 'kill t))))) Why do we need to invent a small language for that? Stefan