From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Merging scratch/substitute-command-keys to master Date: Sun, 18 Oct 2020 00:09:37 -0400 Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32027"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Oct 18 06:10:51 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kU01y-0008C9-2I for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Oct 2020 06:10:50 +0200 Original-Received: from localhost ([::1]:46878 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kU01x-0006LE-1D for ged-emacs-devel@m.gmane-mx.org; Sun, 18 Oct 2020 00:10:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kU012-0005Pp-3g for emacs-devel@gnu.org; Sun, 18 Oct 2020 00:09:53 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14624) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kU00z-0006xv-MX for emacs-devel@gnu.org; Sun, 18 Oct 2020 00:09:51 -0400 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 8DC3210022E; Sun, 18 Oct 2020 00:09:46 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id F31EE10001F; Sun, 18 Oct 2020 00:09:44 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1602994185; bh=N971HtgBbVmV4YMenl33seA4zW6lPw88lAKl+1PRKho=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=g8tOWVXOMpWA7YewctAEKOIwIfxkccU2k8boU/N4GghG7KjhRFJXmK1XtRCWjy2U1 yZu4to3o/h/dQJTPLTlKrX/6B8/gVlZZnBJaiuy7TiWHehd+Mfdgcy48B6PgSt2I8u PzSKIG9dHquBMM0M7ty8AipG9t9+dBMZatDfTOEBbg3oKOxVV0a8fncin/7OEVesQE DMw9Rd00fk0StxcH6fbSviHcWoXVl1LNVMuxa9/dj0mSBVo/CDZjEIC3GZyvcPsRBN jynanePFVxhxvDm49qDx9zvKLuAiWsbo/kTuMZWNrLNHDsnySzaCYl8wlTPKNwwZjo Jmnus6H5hMBIA== Original-Received: from alfajor (unknown [157.52.9.240]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CB70F12031F; Sun, 18 Oct 2020 00:09:44 -0400 (EDT) In-Reply-To: (Stefan Kangas's message of "Sat, 17 Oct 2020 23:35:31 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/18 00:09:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:257986 Archived-At: > I tried using AUTO_STRING at first, but these strings are passed to > Qdescribe_map_tree so that leads to segfault if there is a GC. Oh, right! Oops! >> The code says VECTOR_OR_CHAR_TABLE, so your function's name might want >> to do the same. Or maybe call it `describe-vector` since it seems to be >> a thin wrapper around that function. > > The problem is that there is already a `describe-vector' with a > different calling convention. So perhaps we should just go with > `describe-vector-or-char-table' (clunky as it may be) if no one has a > better proposal. Or maybe `help--describe-vector' is better? Or the > iniquitous `help--describe-vector-or-char-table'? I think this function's name deserves a double dash, in any case. Stefan