From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Stefan Kangas <stefan@marxist.se>
Cc: emacs-devel@gnu.org
Subject: Re: Merging scratch/substitute-command-keys to master
Date: Sun, 18 Oct 2020 00:09:37 -0400 [thread overview]
Message-ID: <jwvy2k4mb09.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CADwFkmnM8yMLf-UFZjuFqtkkhs+R8G4Ubo+epsS8gZtk+Lwx8g@mail.gmail.com> (Stefan Kangas's message of "Sat, 17 Oct 2020 23:35:31 +0000")
> I tried using AUTO_STRING at first, but these strings are passed to
> Qdescribe_map_tree so that leads to segfault if there is a GC.
Oh, right! Oops!
>> The code says VECTOR_OR_CHAR_TABLE, so your function's name might want
>> to do the same. Or maybe call it `describe-vector` since it seems to be
>> a thin wrapper around that function.
>
> The problem is that there is already a `describe-vector' with a
> different calling convention. So perhaps we should just go with
> `describe-vector-or-char-table' (clunky as it may be) if no one has a
> better proposal. Or maybe `help--describe-vector' is better? Or the
> iniquitous `help--describe-vector-or-char-table'?
I think this function's name deserves a double dash, in any case.
Stefan
next prev parent reply other threads:[~2020-10-18 4:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 14:03 Merging scratch/substitute-command-keys to master Stefan Kangas
2020-10-17 15:05 ` Eli Zaretskii
2020-10-17 16:19 ` Stefan Monnier
2020-10-17 23:35 ` Stefan Kangas
2020-10-18 4:09 ` Stefan Monnier [this message]
2020-10-18 11:42 ` Stefan Kangas
2020-10-18 16:11 ` Stefan Kangas
2020-10-17 17:22 ` Drew Adams
2020-10-17 17:46 ` Stefan Kangas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy2k4mb09.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=stefan@marxist.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.