From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Philipp <p.stephani2@gmail.com>
Cc: 41988@debbugs.gnu.org
Subject: bug#41988: 28.0.50; Edebug unconditionally instruments definitions with &define specs
Date: Sun, 21 Mar 2021 10:37:44 -0400 [thread overview]
Message-ID: <jwvy2egwpf3.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <3619E155-8F06-4F8F-B239-121ED3D164A8@gmail.com> (Philipp's message of "Sun, 21 Mar 2021 14:34:08 +0100")
>> - The old spec of `cl-flet` would be broken by such a change, so if we
>> want to make such a change, we'd probably want to arrange so that it
>> emits a clear warning.
> Where? When setting the debug specification (byte-run--set-debug), or in some other place?
The old spec was of the form (or (&define name form) (&define name sexp
body)), so if we put a gate at `&define`, this will probably fail to even match
the (&define name sexp body) part.
[ Disclaimer: I don't understand the precise semantics of `gate`, tho
I do remember using it once via trial-and-error. So maybe it wouldn't
prevent it, but if doesn't prevent it, then it doesn't likely "fix"
our problem ;-) ]
>> I'm not sure it's worth the trouble: the pain seems higher than the gain.
> This bug is rather nasty when it's hit (it took me quite a while to
> debug/hunt down),
Could you remind me what was this nasty outcome? In the context of
Edebug the effect is negligible (it just emits a spurious message about
defining an extra something, but other than that debugging works just fine).
> so I think it would be reasonable to prevent. We already
> disable backtracking for literal symbols, and I think forms that require
> multiple &define forms with backtracking should be exceedingly rare and can
> be rewritten as you did with cl-flet.
Emitting a warning would be much more helpful than just silently
"cut"ting the backtracking.
Stefan
next prev parent reply other threads:[~2021-03-21 14:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 16:58 bug#41988: 28.0.50; Edebug unconditionally instruments definitions with &define specs Philipp
[not found] ` <mailman.222.1592758804.2574.bug-gnu-emacs@gnu.org>
2020-06-21 23:48 ` Alan Mackenzie
2020-08-08 11:01 ` Philipp Stephani
2020-08-08 14:59 ` Alan Mackenzie
2020-08-09 11:33 ` Philipp Stephani
2020-08-09 16:35 ` Alan Mackenzie
2020-08-10 13:32 ` Philipp Stephani
2021-03-02 15:59 ` Stefan Monnier
2021-03-02 17:28 ` Philipp Stephani
2021-03-08 16:33 ` Philipp Stephani
2021-03-08 16:37 ` Philipp Stephani
2021-03-08 17:41 ` Stefan Monnier
2021-03-14 16:32 ` Philipp
2021-03-14 17:38 ` Stefan Monnier
2021-03-18 11:19 ` Philipp
2021-03-18 14:01 ` Stefan Monnier
2021-03-21 13:34 ` Philipp
2021-03-21 14:37 ` Stefan Monnier [this message]
2021-04-04 18:40 ` Philipp Stephani
2021-04-04 20:16 ` Stefan Monnier
2021-04-05 14:32 ` Philipp Stephani
2021-04-10 15:07 ` Philipp
2021-04-10 15:51 ` Stefan Monnier
2021-04-10 16:23 ` Philipp
2021-04-10 17:29 ` Eli Zaretskii
2021-04-10 18:12 ` Stefan Monnier
2021-04-10 19:54 ` Philipp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy2egwpf3.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=41988@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.