* Re: [elpa] externals/vertico 5bbddb0 03/48: add while-no-input-ignore-events
[not found] ` <20210405145439.787C5209C7@vcs0.savannah.gnu.org>
@ 2021-04-05 15:08 ` Stefan Monnier
2021-04-05 18:02 ` Daniel Mendler
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2021-04-05 15:08 UTC (permalink / raw)
To: Daniel Mendler; +Cc: emacs-devel
> add while-no-input-ignore-events
> Thanks, @clemera
[...]
> "Preprocess candidates with INPUT string and METADATA."
> - (pcase (while-no-input (minicomp--candidates input metadata))
> + (pcase (let ((while-no-input-ignore-events '(selection-request)))
> + (while-no-input (minicomp--candidates input metadata)))
I don't understand why you do that.
Was the intention to add `selection-request` to `while-no-input-ignore-events`,
or to remove everything else from it (which is what it does)?
If so, why?
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [elpa] externals/vertico 5bbddb0 03/48: add while-no-input-ignore-events
2021-04-05 15:08 ` [elpa] externals/vertico 5bbddb0 03/48: add while-no-input-ignore-events Stefan Monnier
@ 2021-04-05 18:02 ` Daniel Mendler
2021-04-05 19:02 ` Stefan Monnier
0 siblings, 1 reply; 4+ messages in thread
From: Daniel Mendler @ 2021-04-05 18:02 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> I don't understand why you do that.
> Was the intention to add `selection-request` to `while-no-input-ignore-events`,
> or to remove everything else from it (which is what it does)?
> If so, why?
Icomplete does the same, but I am not sure about all the implications of
this setting. The setting is supposed to ignore certain spurious events
which would prevent the UI from updating.
Generally the idea is that the expensive candidate recomputation and
expensive sorting (vertico--recompute-candidates) is interruptible, such
that the UI stays responsive. The computation is started again when the
next event comes in.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [elpa] externals/vertico 5bbddb0 03/48: add while-no-input-ignore-events
2021-04-05 18:02 ` Daniel Mendler
@ 2021-04-05 19:02 ` Stefan Monnier
2021-04-05 19:25 ` Daniel Mendler
0 siblings, 1 reply; 4+ messages in thread
From: Stefan Monnier @ 2021-04-05 19:02 UTC (permalink / raw)
To: Daniel Mendler; +Cc: emacs-devel
>> I don't understand why you do that.
>> Was the intention to add `selection-request` to `while-no-input-ignore-events`,
>> or to remove everything else from it (which is what it does)?
>> If so, why?
> Icomplete does the same, but I am not sure about all the implications of
> this setting.
Oh I see. This is bug#38024. Thanks.
I just sent a message to that bug, you might like to see what comes out.
> Generally the idea is that the expensive candidate recomputation and
> expensive sorting (vertico--recompute-candidates) is interruptible, such
> that the UI stays responsive. The computation is started again when the next
> event comes in.
That describes the use of `while-no-input`, which I perfectly
understand, but that doesn't explain the `while-no-input-ignore-events`
binding around it which will (IIUC) make it abort whenever you focus
in/out, for example.
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-04-05 19:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20210405145429.5891.40124@vcs0.savannah.gnu.org>
[not found] ` <20210405145439.787C5209C7@vcs0.savannah.gnu.org>
2021-04-05 15:08 ` [elpa] externals/vertico 5bbddb0 03/48: add while-no-input-ignore-events Stefan Monnier
2021-04-05 18:02 ` Daniel Mendler
2021-04-05 19:02 ` Stefan Monnier
2021-04-05 19:25 ` Daniel Mendler
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.