all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: feature/native-comp f842816 2/3: Fix native compiler string hash consing strategy (bug#47868)
       [not found] ` <20210421154118.64DF720E57@vcs0.savannah.gnu.org>
@ 2021-04-21 19:25   ` Stefan Monnier
  2021-04-21 21:14     ` Andrea Corallo via Emacs development discussions.
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2021-04-21 19:25 UTC (permalink / raw)
  To: emacs-devel; +Cc: Andrea Corallo

> +(define-hash-table-test 'comp-imm-equal-test #'equal-including-properties

Why not call it `equal-including-properties`?

> +  (lambda (x)
> +    (sxhash-equal-including-properties x)))

Aka #'sxhash-equal-including-properties, right?


        Stefan




^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: feature/native-comp f842816 2/3: Fix native compiler string hash consing strategy (bug#47868)
  2021-04-21 19:25   ` feature/native-comp f842816 2/3: Fix native compiler string hash consing strategy (bug#47868) Stefan Monnier
@ 2021-04-21 21:14     ` Andrea Corallo via Emacs development discussions.
  0 siblings, 0 replies; 2+ messages in thread
From: Andrea Corallo via Emacs development discussions. @ 2021-04-21 21:14 UTC (permalink / raw)
  To: Stefan Monnier; +Cc: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> +(define-hash-table-test 'comp-imm-equal-test #'equal-including-properties
>
> Why not call it `equal-including-properties`?

I had 2 little thoughts: in the future we might want to tweak further
the hash consing strategy, I didn't know in which file was more
apropriate to define `equal-including-properties'.

>> +  (lambda (x)
>> +    (sxhash-equal-including-properties x)))
>
> Aka #'sxhash-equal-including-properties, right?

Ops! :/

Thanks

  Andrea



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-21 21:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <20210421154116.4643.11559@vcs0.savannah.gnu.org>
     [not found] ` <20210421154118.64DF720E57@vcs0.savannah.gnu.org>
2021-04-21 19:25   ` feature/native-comp f842816 2/3: Fix native compiler string hash consing strategy (bug#47868) Stefan Monnier
2021-04-21 21:14     ` Andrea Corallo via Emacs development discussions.

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.