all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Jimmy Yuen Ho Wong <wyuenho@gmail.com>
Cc: 48153-done@debbugs.gnu.org,
	Gregory Heytings <gregory@heytings.org>,
	Eli Zaretskii <eliz@gnu.org>
Subject: bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer
Date: Sun, 09 May 2021 10:57:07 -0400	[thread overview]
Message-ID: <jwvy2cox8i5.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAKDRQS5kWZhxe-TMD6irJzUQYQOHs1RT=yQV2=VCrDpF3K-3+w@mail.gmail.com> (Jimmy Yuen Ho Wong's message of "Thu, 6 May 2021 11:55:25 +0100")

> Ok I think I've found a solution to my problem. There are a couple of
> things that I didn't understand and had to attach a function to print
> out which one is being called on 5 different hooks to find out the
> invocation order.
>
> This is call order I've found:
>
> 1. ido-setup-hook
> 2. minibuffer-mode-hook
> 3. minibuffer-setup-hook
> 4. minibuffer-exit-hook
> 5. minibuffer-inactive-mode-hook
>
> Specifically, the override keymaps are cleared between step 1 and 2,
> so if I loop thru the minibuffers in step 1 to assign to
> minor-mode-override-map-alist inside them, they will be reset in step
> 2 I suppose.

Indeed, `ido-setup-hook` is run after IDO has configured its own keymaps
and variables, but hasn't yet entered the minibuffer, so it's too early
to work on `minor-mode-override-map-alist`.

> So if I needed to "unshadow" the shadowed keybindings inside the
> minibuffer, I had to do these processing in minibuffer-setup-hook
> because that is called every time the minibuffer is entered.

That's right.

> Thanks for your help, you can close this issue now.

Closing, thanks,


        Stefan






  reply	other threads:[~2021-05-09 14:57 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-02  6:58 bug#48153: 28.0.50; minor mode keymaps should not override keymap given to read-from-minibuffer Jimmy Yuen Ho Wong
2021-05-03 15:15 ` Gregory Heytings
2021-05-04 12:53   ` Jimmy Yuen Ho Wong
2021-05-04 13:13     ` Gregory Heytings
2021-05-04 13:52       ` Jimmy Yuen Ho Wong
2021-05-04 14:02         ` Gregory Heytings
2021-05-04 14:29           ` Gregory Heytings
2021-05-04 16:15             ` Jimmy Yuen Ho Wong
2021-05-04 16:36               ` Gregory Heytings
2021-05-04 22:40                 ` Jimmy Yuen Ho Wong
2021-05-05  8:09                   ` Gregory Heytings
2021-05-05  9:10                     ` Jimmy Yuen Ho Wong
2021-05-05 12:15                       ` Eli Zaretskii
2021-05-05 13:12                         ` Gregory Heytings
2021-05-05 13:24                           ` Jimmy Yuen Ho Wong
2021-05-05 14:17                             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-05-06 10:55                               ` Jimmy Yuen Ho Wong
2021-05-09 14:57                                 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
2021-05-05 13:06                       ` Gregory Heytings
2021-05-05 14:05     ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwvy2cox8i5.fsf-monnier+emacs@gnu.org \
    --to=bug-gnu-emacs@gnu.org \
    --cc=48153-done@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=gregory@heytings.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=wyuenho@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.