From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#56469: 29.0.50; Unibyte dir in directory_files_internal Date: Sun, 10 Jul 2022 11:19:22 -0400 Message-ID: References: <83y1x2177x.fsf@gnu.org> <83bktx11ji.fsf@gnu.org> <83a69h0zwz.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32577"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56469@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Jul 10 17:20:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oAYjK-0008HH-8k for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jul 2022 17:20:18 +0200 Original-Received: from localhost ([::1]:54144 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oAYjJ-0002vJ-09 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 10 Jul 2022 11:20:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38632) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oAYj4-0002te-OI for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 11:20:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:43813) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oAYj4-0000La-F4 for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 11:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oAYj4-00056c-5n for bug-gnu-emacs@gnu.org; Sun, 10 Jul 2022 11:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 10 Jul 2022 15:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56469 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56469-submit@debbugs.gnu.org id=B56469.165746637319584 (code B ref 56469); Sun, 10 Jul 2022 15:20:02 +0000 Original-Received: (at 56469) by debbugs.gnu.org; 10 Jul 2022 15:19:33 +0000 Original-Received: from localhost ([127.0.0.1]:37710 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAYib-00055n-9d for submit@debbugs.gnu.org; Sun, 10 Jul 2022 11:19:33 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:17704) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oAYiZ-00055Z-Ll for 56469@debbugs.gnu.org; Sun, 10 Jul 2022 11:19:32 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id E6934440980; Sun, 10 Jul 2022 11:19:25 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 99C6144067E; Sun, 10 Jul 2022 11:19:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1657466364; bh=rfudo7eijaRdLG0ycM2MUOc9Mc0U1jLXWE7S93Cy7zA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FynnPNMrm/1MAgGhXfIDCdhOEXh6J80NmNEQLM8ZgsgkVzPeCobKXKnXtxCAXhysq ZUxNPXLs14v9kYdOcW/OkrjNYd4NJCN+LUbS8If42pHjMmG57rQXncBClUpoICUmhS S0bAsgNzT4b8lJSs1f3WIaQRCip18wQw1O+vkBqv+RzUU0g6DaZ3SnWHWfL/b3Fi+P ihw1ZFsIrV8TD/LEGO37YgeQwOlplawZW/VAq7YjzoLuhiB0YvcyDluaMw/SA4qBqb dTcAR7aUgina9JkcdIM2DJgxnd9B86kIH0xLJQb3H2oQRe2BlCS9j8Efc3tWODq4YV 5a0fVtGu/24jQ== Original-Received: from pastel (unknown [45.72.196.165]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 60904120506; Sun, 10 Jul 2022 11:19:24 -0400 (EDT) In-Reply-To: <83a69h0zwz.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 10 Jul 2022 18:07:24 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236584 Archived-At: > That could be the situation _today_, but that's just sheer luck (or > lack thereof). In general, all the file-handling code we have in > fileio.c and dired.c should be equally prepared to handle unibyte > non-ASCII file names and multibyte file names, because we may need > that any time. When we make changes in Emacs, we shouldn't be worried > whether those changes could cause some dired.c code be called early on > during Emacs startup. Agreed. In the updated comment I noted that we have a bug when we do (let ((file-name-coding-system 'binary)) (directory-files "/tmp/=E9t=E9/" 'full) because we'll be concatenating the multibyte string "/tmp/=E9t=E9/" with the undecoded unibyte strings of the names of files in that directory. Stefan