From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [nongnu] elpa/evil 460af439e5: Suppress operator for some normal state commands Date: Fri, 07 Oct 2022 20:01:34 -0400 Message-ID: References: <166483070487.28727.16591732760971661957@vcs2.savannah.gnu.org> <20221003205825.2E812C11D79@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25692"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Tom Dalziel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 08 02:02:35 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogxIZ-0006Tj-2w for ged-emacs-devel@m.gmane-mx.org; Sat, 08 Oct 2022 02:02:35 +0200 Original-Received: from localhost ([::1]:58900 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogxIX-0006qg-Fj for ged-emacs-devel@m.gmane-mx.org; Fri, 07 Oct 2022 20:02:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogxHi-000693-0E for emacs-devel@gnu.org; Fri, 07 Oct 2022 20:01:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:46493) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogxHe-0001yS-Se for emacs-devel@gnu.org; Fri, 07 Oct 2022 20:01:40 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5F9E54437C0; Fri, 7 Oct 2022 20:01:37 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C6A154437BC; Fri, 7 Oct 2022 20:01:35 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1665187295; bh=HITzSrd45d3/H0BWMEaPyNRBcbFmRyHsrgzjD385+4k=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=o8ZiuEveJZREdklDaVVFoWP3RB/dlMxYyg6NamElAJjTzLj6V3O8uHuex4nVC0m6O oUc3lz16JQXXloglSqHPF2aIbg/Zy3XnyIeJHIEG0XhP5QEy+tofXw5wxREK6uD/To kXha/GJSYwlMivf6PyaJfsulVQT96ReOdPbly3XH0bz5U+EaKuf185thu3l6v1wC82 dMIZPhuBDjIkKOB4rcYndLS5UYSJG2knqHkPdlHr21n/TflK92p64OUwAfZtvGvaea Ts3P9idXOgWSKXufo/YhgTsnKi9JEm9/ut/9XAkPFj0bMHpWO9SaBNMp3uia4L52aN FLe1Hhbb5n0fg== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 9F41E120D85; Fri, 7 Oct 2022 20:01:35 -0400 (EDT) In-Reply-To: <20221003205825.2E812C11D79@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Mon, 3 Oct 2022 16:58:25 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297185 Archived-At: ELPA Syncer [2022-10-03 16:58:25] wrote: > branch: elpa/evil > commit 460af439e51da7f6602732318ff52820bd2286fd > Author: Tom Dalziel > Commit: Tom Dalziel <33435574+tomdl89@users.noreply.github.com> > > Suppress operator for some normal state commands [...] > @@ -2002,11 +2093,12 @@ with regard to indentation." > (or (and (>= char ?A) (<= char ?Z)) > (assq char (default-value 'evil-markers-alist)))) > > -(defun evil-set-marker (char &optional pos advance) > +(evil-define-command evil-set-marker (char &optional pos advance) > "Set the marker denoted by CHAR to position POS. > POS defaults to the current position of point. > If ADVANCE is t, the marker advances when inserting text at it; > otherwise, it stays behind." > + :suppress-operator t > (interactive (list (read-char))) > (catch 'done > (let ((marker (evil-get-marker char t)) alist) This hunk breaks compilation of `evil-common.el` (unless you call the compiler after you loaded that non-compiled file, to fix the circularity by hand): When compiling the file, the compiler needs to macro expand this `evil-define-command`. The macro is defined a few lines earlier, so that part works fine, but the macro calls during its expansion a few other functions defined in that same file: while the functions are defined earlier in the file, this still breaks because when the file is compiled the `defun`s are not yet executed (i.e. the functions get compiled but they don't get defined). So we get an error of the form: Error: void-function (evil-interactive-form) debug(error (void-function evil-interactive-form)) evil-interactive-form((list (read-char))) apply(evil-interactive-form (list (read-char))) [...] macroexpand-1((evil-define-command evil-set-marker ... [...] To fix this, we need either: - wrap inside `eval-and-compile` all the functions used during the macro expansion of `evil-define-command`. - Move the definition of `evil-set-marker` to another file, like `evil-commands.el`. Stefan