From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Tom Dalziel <tom_dl@hotmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: [nongnu] elpa/evil 460af439e5: Suppress operator for some normal state commands
Date: Fri, 07 Oct 2022 20:01:34 -0400 [thread overview]
Message-ID: <jwvy1tr2nrw.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20221003205825.2E812C11D79@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Mon, 3 Oct 2022 16:58:25 -0400 (EDT)")
ELPA Syncer [2022-10-03 16:58:25] wrote:
> branch: elpa/evil
> commit 460af439e51da7f6602732318ff52820bd2286fd
> Author: Tom Dalziel <tom_dl@hotmail.com>
> Commit: Tom Dalziel <33435574+tomdl89@users.noreply.github.com>
>
> Suppress operator for some normal state commands
[...]
> @@ -2002,11 +2093,12 @@ with regard to indentation."
> (or (and (>= char ?A) (<= char ?Z))
> (assq char (default-value 'evil-markers-alist))))
>
> -(defun evil-set-marker (char &optional pos advance)
> +(evil-define-command evil-set-marker (char &optional pos advance)
> "Set the marker denoted by CHAR to position POS.
> POS defaults to the current position of point.
> If ADVANCE is t, the marker advances when inserting text at it;
> otherwise, it stays behind."
> + :suppress-operator t
> (interactive (list (read-char)))
> (catch 'done
> (let ((marker (evil-get-marker char t)) alist)
This hunk breaks compilation of `evil-common.el` (unless you call the
compiler after you loaded that non-compiled file, to fix the
circularity by hand):
When compiling the file, the compiler needs to macro expand this
`evil-define-command`. The macro is defined a few lines earlier, so
that part works fine, but the macro calls during its expansion a few
other functions defined in that same file: while the functions are
defined earlier in the file, this still breaks because when the file is
compiled the `defun`s are not yet executed (i.e. the functions get
compiled but they don't get defined). So we get an error of the form:
Error: void-function (evil-interactive-form)
debug(error (void-function evil-interactive-form))
evil-interactive-form((list (read-char)))
apply(evil-interactive-form (list (read-char)))
[...]
macroexpand-1((evil-define-command evil-set-marker ...
[...]
To fix this, we need either:
- wrap inside `eval-and-compile` all the functions used during the macro
expansion of `evil-define-command`.
- Move the definition of `evil-set-marker` to another file, like
`evil-commands.el`.
Stefan
parent reply other threads:[~2022-10-08 0:01 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20221003205825.2E812C11D79@vcs2.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvy1tr2nrw.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=tom_dl@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.