bug#64290: “named-let” doc bug?

bug#64290: “named-let” doc bug?

[Shynur Xie]

The following code seems fine semantically and grammatically:

    ;; -*- lexical-binding: nil; -*-
    (named-let f ((n 1))
      (dotimes (i n)
        (f 0)))

But it throws error.

Perhaps we should clarify that “‘named-let’ works as expected only
when ‘lexical-binding’ is enabled” in relevant doc?

--
shynur

bug#64290: “named-let” doc bug?

[Eli Zaretskii]

> From: Shynur Xie <one.last.kiss@outlook.com>
> Date: Sun, 25 Jun 2023 23:16:41 +0000
> msip_labels: 
> 
> The following code seems fine semantically and grammatically:
> 
>     ;; -*- lexical-binding: nil; -*-
>     (named-let f ((n 1))
>       (dotimes (i n)
>         (f 0)))
> 
> But it throws error.
> 
> Perhaps we should clarify that “‘named-let’ works as expected only
> when ‘lexical-binding’ is enabled” in relevant doc?

Stefan, any comments?

bug#64290: “named-let” doc bug?

[Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors]

>> The following code seems fine semantically and grammatically:
>> 
>>     ;; -*- lexical-binding: nil; -*-
>>     (named-let f ((n 1))
>>       (dotimes (i n)
>>         (f 0)))
>> 
>> But it throws error.
>> 
>> Perhaps we should clarify that “‘named-let’ works as expected only
>> when ‘lexical-binding’ is enabled” in relevant doc?
>
> Stefan, any comments?

That or adding a check in `named-let` and raise an error when applicable.


        Stefan

bug#64290: “named-let” doc bug?

[Eli Zaretskii]

> From: Stefan Monnier <monnier@iro.umontreal.ca>
> Cc: Shynur Xie <one.last.kiss@outlook.com>,  64290@debbugs.gnu.org
> Date: Mon, 26 Jun 2023 09:59:13 -0400
> 
> >> The following code seems fine semantically and grammatically:
> >> 
> >>     ;; -*- lexical-binding: nil; -*-
> >>     (named-let f ((n 1))
> >>       (dotimes (i n)
> >>         (f 0)))
> >> 
> >> But it throws error.
> >> 
> >> Perhaps we should clarify that “‘named-let’ works as expected only
> >> when ‘lexical-binding’ is enabled” in relevant doc?
> >
> > Stefan, any comments?
> 
> That or adding a check in `named-let` and raise an error when applicable.

I went with the former on the release branch.  I think raising an
error is only appropriate for the master branch, if we even think it's
a good idea.