From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67005: 30.0.50; improve nadivce/comp/trampoline handling Date: Thu, 23 Nov 2023 11:38:54 -0500 Message-ID: References: <874jhv9921.fsf@sappc2.fritz.box> <875y24zrt1.fsf@sappc2.fritz.box> <87ttpmwuxi.fsf@sappc2.fritz.box> <877cmct4a1.fsf@sappc2.fritz.box> <87bkbmiwpf.fsf@sappc2.fritz.box> <87leap8n1z.fsf@sappc2.fritz.box> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25928"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Jens Schmidt , 67005@debbugs.gnu.org To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Nov 23 17:40:46 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6Ckv-0006Wy-Q1 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 23 Nov 2023 17:40:45 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6Cki-0007Hq-Ei; Thu, 23 Nov 2023 11:40:33 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6CkH-00079D-H3 for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 11:40:11 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6Ck9-0003oT-Uz for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 11:39:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6CkD-0004xd-SX for bug-gnu-emacs@gnu.org; Thu, 23 Nov 2023 11:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 23 Nov 2023 16:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67005 X-GNU-PR-Package: emacs Original-Received: via spool by 67005-submit@debbugs.gnu.org id=B67005.170075754718964 (code B ref 67005); Thu, 23 Nov 2023 16:40:01 +0000 Original-Received: (at 67005) by debbugs.gnu.org; 23 Nov 2023 16:39:07 +0000 Original-Received: from localhost ([127.0.0.1]:34957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6CjK-0004vj-Oc for submit@debbugs.gnu.org; Thu, 23 Nov 2023 11:39:06 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:32883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6CjJ-0004ux-8b for 67005@debbugs.gnu.org; Thu, 23 Nov 2023 11:39:05 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E407F806F7; Thu, 23 Nov 2023 11:38:55 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700757535; bh=ueB0HJPkhOhdbDcTVZagjMOQqTcZVRo2T7W8LdVM/+E=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WIM9SQ7T+8O/S374qUq2kMgx4IAT0ZxdBpiGKcIHcO2cWRqmV4Y84l/VelrPDa0Ye W5iWJbEIAwoHkeWh92CaSLWA/v9RkxKTfM0lxHV2eI51l+v/80GNQ95hPg8G4Wj/xZ TLcTmsJ5NiQ9rDTBqGghVDEOg6EKlVmXCKYmKE6XMBGOYdTFtNtREuN8uwR/uy6f6G rFIUpW24IuF9pe6AMqpqVOgFvyNHF9HeiP3aQy9J6NupqqggB8Ptsbt1ghPS7Vlh0N Gpbn/pq8o0KdXdR4LqJvoKovJqUnS1eUzP6RjeHhae1tO+tjje+UXa5D0Fx0FhNCV8 9VKzihQAfnBlQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 302208025F; Thu, 23 Nov 2023 11:38:55 -0500 (EST) Original-Received: from alfajor (modemcable005.21-80-70.mc.videotron.ca [70.80.21.5]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id DAA4712044B; Thu, 23 Nov 2023 11:38:54 -0500 (EST) In-Reply-To: (Stefan Monnier's message of "Thu, 23 Nov 2023 11:24:59 -0500") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274817 Archived-At: >>> + (when purify-flag >>> + (error "Invalid pre-dump advice on %s" symbol)) >>> (let* ((f (symbol-function symbol)) >>> (nf (advice--normalize symbol f))) >>> (unless (eq f nf) (fset symbol nf)) >> >> The patch LGTM thanks, just one question: should we guard in advice.el >> as well just to stay on the safe side? > > Since `defadvice` is now marked as obsolete, it seems highly unlikely > that we'd end up adding an old-style advice to a preloaded file. More to the point: no it's not necessary since `advice.el` uses `advice-add` to install its pieces of advice, so the test in `nadvice.el` already covers it. Stefan