From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Sat, 25 Nov 2023 16:38:34 -0500 Message-ID: References: <87il7ib6cu.fsf@posteo.net> <875y3386ep.fsf@posteo.net> <87a5sddh14.fsf@web.de> <8734y5vnj7.fsf@posteo.net> <87bkcslr18.fsf@web.de> <87y1fwtyrl.fsf@posteo.net> <87y1fut1wp.fsf@web.de> <87ttqgpjiz.fsf@posteo.net> <87wmvbibpr.fsf@web.de> <877cnb2n63.fsf@posteo.net> <8734xyc8z0.fsf@web.de> <87zg05rewi.fsf@posteo.net> <87ttqcg8gw.fsf@web.de> <87h6mcr8ol.fsf@posteo.net> <87r0l73029.fsf@web.de> <877cmdx8ud.fsf@posteo.net> <87sf50s1gh.fsf@posteo.net> <83o7ficesp.fsf@gnu.org> <878r6leh9d.fsf@posteo.net> <83il5pbnmh.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3730"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Thierry Volpiatto , michael_heerdegen@web.de, stefankangas@gmail.com, 66394@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 22:39:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r70Mn-0000lO-WB for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 22:39:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r70Mc-0004mH-Cu; Sat, 25 Nov 2023 16:38:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r70Mb-0004lu-1D for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 16:38:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r70Ma-0004G8-NR for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 16:38:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r70Mf-0004jF-T1 for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 16:39:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 21:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.170094833418157 (code B ref 66394); Sat, 25 Nov 2023 21:39:01 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 25 Nov 2023 21:38:54 +0000 Original-Received: from localhost ([127.0.0.1]:40399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r70MY-0004im-4a for submit@debbugs.gnu.org; Sat, 25 Nov 2023 16:38:54 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:20594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r70MW-0004iU-1T for 66394@debbugs.gnu.org; Sat, 25 Nov 2023 16:38:52 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id D3E258044C; Sat, 25 Nov 2023 16:38:40 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1700948315; bh=98aB3axXC25kohRW+FpBDECEO48xUMYS/CUT9mH1UYU=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=db3FvrfqmLgSIYp/eIdk7GfmVbV/0DTH+XEP6SBACK08r62eG/Ne0qKdgjlWZ2sjq JfnhYX6C85BEoUXvJshJeU6rnlvHWG3v+8mfLBBXXXlUJG/0zhmf7/hTrro6jWKR45 q3PUgNSR2J78IF1KWT/OEN1CnYXXYJfevdMmFvK/iTNzS4m9VkCQqIVZWJoZbJl1sZ aE0Wlip8qxGoyEufAiUD1WZ9II4QSTLLnyjpMWukVw3mHcbe+3uGEHZb2gGYPGzdKg Le5gbFFyPRfihBgLr6+LRiMo3432OGjdoLNnPLptLTkEeChYWy/pHeyduBnumPKjQm 6z+ZAaIAJdRcg== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id DF8C280506; Sat, 25 Nov 2023 16:38:35 -0500 (EST) Original-Received: from pastel (unknown [45.72.227.120]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A7C671202E6; Sat, 25 Nov 2023 16:38:35 -0500 (EST) In-Reply-To: <83il5pbnmh.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 25 Nov 2023 22:10:14 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275021 Archived-At: >> > In toplevel form: >> > register.el:33:37: Warning: `eql' called with 1 argument, but requires 2 >> > register.el:33:45: Warning: reference to free variable `integer' >> I have not these warnings. > Strange. Maybe Stefan can explain how could that happen. It's because of: (cl--generic-prefill-dispatchers 0 (eql 'x) integer) This needs to be in `cl-generic.el` because that's where the `cl--generic-prefill-dispatchers` macro is defined. Thierry had it in `register.el` which worked OK when `register.el` gets compiled with the bootstrap Emacs where `cl-generic` has not yet been compiled but it fails when compiled with an Emacs where `cl-generic` has been compiled because in that case the macro is not defined so the compiler compiles the above line as a function call, resulting in the above two warnings. Stefan