From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Fwd: Patch for sgml-mode.el Date: Thu, 29 Nov 2007 23:46:57 -0500 Message-ID: References: <0o4pfcvird.fsf@fencepost.gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1196398041 13553 80.91.229.12 (30 Nov 2007 04:47:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 30 Nov 2007 04:47:21 +0000 (UTC) Cc: Martin Pohlack , rms@gnu.org, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Nov 30 05:47:28 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Ixxmh-0005E0-AH for ged-emacs-devel@m.gmane.org; Fri, 30 Nov 2007 05:47:27 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IxxmR-0005VF-Cf for ged-emacs-devel@m.gmane.org; Thu, 29 Nov 2007 23:47:11 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IxxmN-0005Uo-Ii for emacs-devel@gnu.org; Thu, 29 Nov 2007 23:47:07 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IxxmL-0005UV-MF for emacs-devel@gnu.org; Thu, 29 Nov 2007 23:47:06 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IxxmL-0005US-HF for emacs-devel@gnu.org; Thu, 29 Nov 2007 23:47:05 -0500 Original-Received: from tomts22-srv.bellnexxia.net ([209.226.175.184]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IxxmF-0008Li-Ea; Thu, 29 Nov 2007 23:46:59 -0500 Original-Received: from toip5.srvr.bell.ca ([209.226.175.88]) by tomts22-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20071130044658.OYDD18413.tomts22-srv.bellnexxia.net@toip5.srvr.bell.ca>; Thu, 29 Nov 2007 23:46:58 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ah4FAAolT0dGN4zh/2dsb2JhbACBWw Original-Received: from bas1-montreal42-1178045665.dsl.bell.ca (HELO pastel.home) ([70.55.140.225]) by toip5.srvr.bell.ca with ESMTP; 29 Nov 2007 23:49:14 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id A5AEA7F62; Thu, 29 Nov 2007 23:46:57 -0500 (EST) In-Reply-To: <0o4pfcvird.fsf@fencepost.gnu.org> (Glenn Morris's message of "Fri, 23 Nov 2007 14:55:50 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.50 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Solaris 8 (1) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:84330 Archived-At: >>>>> "GM" == Glenn Morris writes: > Stefan Monnier wrote: >>> Furthermore, it results in "mode-name" not being a string >>> for html buffers. >> >> I don't see a problem with that. It's obviously been done on purpose. >> Please describe where it causes a problem so we can fix that spot. > I have being meaning to post about this. > See for example > http://lists.gnu.org/archive/html/emacs-devel/2007-11/msg00891.html > From: h1t > Subject: Bug in ibuffer-mark-by-mode-regexp function > Date: Wed, 14 Nov 2007 10:27:04 +0200 > A quick grep for mode-name in lisp/ appears to show several places > that assume it is a string. It's documented as being a string, so I > would think at the very least should be a NEWS entry saying it might > not be any more. Does the patch below fix those problems? Stefan Index: lisp/ibuffer.el =================================================================== RCS file: /sources/emacs/emacs/lisp/ibuffer.el,v retrieving revision 1.88 diff -u -r1.88 ibuffer.el --- lisp/ibuffer.el 19 Nov 2007 08:50:03 -0000 1.88 +++ lisp/ibuffer.el 30 Nov 2007 04:46:25 -0000 @@ -1722,7 +1722,7 @@ ('mouse-face 'highlight 'keymap ibuffer-mode-name-map 'help-echo "mouse-2: filter by this mode")) - (format "%s" mode-name)) + (format-mode-line mode-name)) (define-ibuffer-column process (:summarizer Index: lisp/ibuf-ext.el =================================================================== RCS file: /sources/emacs/emacs/lisp/ibuf-ext.el,v retrieving revision 1.59 diff -u -r1.59 ibuf-ext.el --- lisp/ibuf-ext.el 23 Oct 2007 15:54:06 -0000 1.59 +++ lisp/ibuf-ext.el 30 Nov 2007 04:46:25 -0000 @@ -1134,11 +1134,11 @@ (string-lessp (downcase (with-current-buffer (car a) - mode-name)) + (format-mode-line mode-name))) (downcase (with-current-buffer (car b) - mode-name)))) + (format-mode-line mode-name))))) ;;;###autoload (autoload 'ibuffer-do-sort-by-alphabetic "ibuf-ext") (define-ibuffer-sorter alphabetic @@ -1386,7 +1386,7 @@ (ibuffer-mark-on-buffer #'(lambda (buf) (with-current-buffer buf - (string-match regexp mode-name))))) + (string-match regexp (format-mode-line mode-name)))))) ;;;###autoload (defun ibuffer-mark-by-file-name-regexp (regexp)